Skip to content

Allow C++ NetworkingModule response handlers (#60023) - #60023

Open
javache wants to merge 1 commit into
react:mainfrom
javache:export-D132255841
Open

javache wants to merge 1 commit into
react:mainfrom
javache:export-D132255841

Conversation

@javache

@javache javache commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Add an optional INetworkingResponseHandler to the C++ NetworkingModule. Hosts can convert supported response types, such as blob responses, into their native JavaScript representation. The existing string/base64 response path remains unchanged when no handler is registered or the handler does not support the response type.

Networking copies the complete IOBuf chain directly into an owned std::vector<uint8_t> and moves it to the response handler on the JavaScript thread. The interface carries undecoded bytes rather than a string, avoiding a string-to-vector conversion.

Changelog: [Internal]

Differential Revision: D132255841

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2026
@meta-codesync

meta-codesync Bot commented Nov 16, 2026

Copy link
Copy Markdown

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D132255841.

@meta-codesync meta-codesync Bot changed the title Allow C++ NetworkingModule response handlers Allow C++ NetworkingModule response handlers (#60023) Nov 16, 2026
javache added a commit to javache/react-native that referenced this pull request Nov 16, 2026
Summary:

Add an optional `INetworkingResponseHandler` to the C++ `NetworkingModule`. Hosts can convert supported response types, such as blob responses, into their native JavaScript representation. The existing string/base64 response path remains unchanged when no handler is registered or the handler does not support the response type.

Networking copies the complete `IOBuf` chain directly into an owned `std::vector<uint8_t>` and moves it to the response handler on the JavaScript thread. The interface carries undecoded bytes rather than a string, avoiding a string-to-vector conversion.

Changelog: [Internal]

Differential Revision: D132255841
meta-codesync Bot pushed a commit that referenced this pull request Nov 16, 2026
## Summary:

The Fantom README FAQ says the tests don't run outside Meta's CI, but Test All already builds the Fantom runner and runs the suite in GitHub Actions (`build_fantom_runner` and `run_fantom_tests`) on every PR that changes code. This updates the answer to match.

Fixes #60028

## Changelog:

[INTERNAL] [CHANGED] - Update the Fantom README FAQ to say tests run on GitHub CI

## Test Plan:

Docs only. Checked the wording against `.github/workflows/test-all.yml` and the Fantom jobs in the Test All run of #60023, and confirmed the relative link to the workflow file resolves.

Differential Revision: D132275666

Pull Request resolved: #60031
javache added a commit to javache/react-native that referenced this pull request Nov 16, 2026
Summary:
Pull Request resolved: react#60023

Add an optional `INetworkingResponseHandler` to the C++ `NetworkingModule`. Hosts can convert supported response types, such as blob responses, into their native JavaScript representation. The existing string/base64 response path remains unchanged when no handler is registered or the handler does not support the response type.

Networking copies the complete `IOBuf` chain directly into an owned `std::vector<uint8_t>` and moves it to the response handler on the JavaScript thread. The interface carries undecoded bytes rather than a string, avoiding a string-to-vector conversion.

Changelog: [Internal]

Differential Revision: D132255841
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Visual regression

No visual differences at 5d607ea3a57d.

javache added a commit to javache/react-native that referenced this pull request Nov 16, 2026
Summary:
Pull Request resolved: react#60023

Add an optional `INetworkingResponseHandler` to the C++ `NetworkingModule`. Hosts can convert supported response types, such as blob responses, into their native JavaScript representation. The existing string/base64 response path remains unchanged when no handler is registered or the handler does not support the response type.

Networking copies the complete `IOBuf` chain directly into an owned `std::vector<uint8_t>` and moves it to the response handler on the JavaScript thread. The interface carries undecoded bytes rather than a string, avoiding a string-to-vector conversion.

Changelog: [Internal]

Differential Revision: D132255841
Summary:

Add an optional `INetworkingResponseHandler` to the C++ `NetworkingModule`. Hosts can convert supported response types, such as blob responses, into their native JavaScript representation. The existing string/base64 response path remains unchanged when no handler is registered or the handler does not support the response type.

Networking copies the complete `IOBuf` chain directly into an owned `std::vector<uint8_t>` and moves it to the response handler on the JavaScript thread. The interface carries undecoded bytes rather than a string, avoiding a string-to-vector conversion.

Changelog: [Internal]

Differential Revision: D132255841
javache added a commit to javache/react-native that referenced this pull request Nov 17, 2026
Summary:
Pull Request resolved: react#60023

Add an optional `INetworkingResponseHandler` to the C++ `NetworkingModule`. Hosts can convert supported response types, such as blob responses, into their native JavaScript representation. The existing string/base64 response path remains unchanged when no handler is registered or the handler does not support the response type.

Networking copies the complete `IOBuf` chain directly into an owned `std::vector<uint8_t>` and moves it to the response handler on the JavaScript thread. The interface carries undecoded bytes rather than a string, avoiding a string-to-vector conversion.

Changelog: [Internal]

Differential Revision: D132255841

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant