Skip to content

Update the Fantom FAQ to say tests run on GitHub CI - #60031

Merged
meta-codesync[bot] merged 2 commits into
react:mainfrom
lazerg:fix/issue-60028-fantom-ci-faq
Nov 16, 2026
Merged

meta-codesync[bot] merged 2 commits into
react:mainfrom
lazerg:fix/issue-60028-fantom-ci-faq

Conversation

@lazerg

@lazerg lazerg commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

The Fantom README FAQ says the tests don't run outside Meta's CI, but Test All already builds the Fantom runner and runs the suite in GitHub Actions (build_fantom_runner and run_fantom_tests) on every PR that changes code. This updates the answer to match.

Fixes #60028

Changelog:

[INTERNAL] [CHANGED] - Update the Fantom README FAQ to say tests run on GitHub CI

Test Plan:

Docs only. Checked the wording against .github/workflows/test-all.yml and the Fantom jobs in the Test All run of #60023, and confirmed the relative link to the workflow file resolves.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2026
@lazerg lazerg changed the title Update Fantom FAQ: tests run on GitHub CI Update the Fantom FAQ to say tests run on GitHub CI Nov 16, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 16, 2026
@meta-codesync

meta-codesync Bot commented Nov 16, 2026

Copy link
Copy Markdown

@javache has imported this pull request. If you are a Meta employee, you can view this in D132275666.

@meta-codesync
meta-codesync Bot merged commit 487979a into react:main Nov 16, 2026
50 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @lazerg in 487979a

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fantom's README says its tests do not run outside of Meta's CI, but Test All runs them in GitHub Actions on pull requests

3 participants