Repository navigation
hdl: use <view>'converse directly in ports rather than the package alias - #538
Merged
Merged
Conversation
Aaron-Hartwig
approved these changes
Oct 7, 2026
Aaron-Hartwig
left a comment
Aaron-Hartwig
left a comment
Collaborator
There was a problem hiding this comment.
Unfortunate, but reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch to work around #523, confirmed that it builds in Vivado 2026.1 where it would previously fail and simulations still work.
I don't love this, but we're going to need to support 2026.1series builds so I think we're stuck with it. This is mostly mechanical and the robots are good at doing this (and the eventual revert) which we can do once we have a new, patched and functional vivado.
I'm still working on build comparisons to make sure there aren't other lingering issues under the hood and will deal with that in Xilinx tickets if required.