Skip to content

feat(install): print how to enable shell completions#1675

Merged
mergify[bot] merged 2 commits into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/print-enable-shell-completions--9231ed40
Jun 25, 2026
Merged

feat(install): print how to enable shell completions#1675
mergify[bot] merged 2 commits into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/print-enable-shell-completions--9231ed40

Conversation

@JulianMaurin

@JulianMaurin JulianMaurin commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

After dropping the binary, print the exact command to enable tab
completion for the detected shell ($SHELL): bash, zsh, and fish each
get a ready-to-paste line; any other shell is pointed at mergify completions. The installer writes nothing into the user's shell dirs.

A curl|sh installer that ships a single binary leaves shell config to
the user, as rustup and starship do; writing completion files from it
is both surprising and unreliable — ~/.zfunc is off zsh's $fpath by
default. Man-page generation stays available via the binary for real
packaging.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Depends-On: #1671

@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 23, 2026 12:10 Failure
This was referenced Jun 23, 2026
Merged
Merged
@JulianMaurin

JulianMaurin commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 fix(cli): render stack-squash validation errors via clap #1671
2 feat(install): print how to enable shell completions #1675 👈
3 docs: make the README a full CLI-contract reference #1676
4 fix(queue): treat a not-queued PR as a normal state, not an API error #1678
5 fix(config): surface an invalid simulate config as a config error #1679
6 fix(ci): return a runtime error when scopes --write fails #1680
7 fix(stack): exit not-found when checkout finds no stack #1681
8 feat(cli): support the git-style help subcommand #1682
9 docs(cli): correct stack reorder and scopes-send help text #1683

@JulianMaurin JulianMaurin mentioned this pull request Jun 23, 2026
Merged
@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 ⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

🟢 🤖 Continuous Integration

  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@JulianMaurin JulianMaurin marked this pull request as ready for review June 23, 2026 12:15
@mergify mergify Bot requested a review from a team June 23, 2026 12:17
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/print-enable-shell-completions--9231ed40 branch from e299829 to 2363101 Compare June 23, 2026 12:38
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735 branch from bf0cbee to cbbb1dd Compare June 23, 2026 12:38
@JulianMaurin

JulianMaurin commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Revision history

# Type Changes Reason Date
1 initial e299829 2026-06-23 12:38 UTC
2 rebase e299829 → 2363101 (rebase only) 2026-06-23 12:38 UTC
3 rebase 2363101 → f05dac8 (rebase only) 2026-06-23 13:08 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 23, 2026 12:39 Failure
JulianMaurin and others added 2 commits June 23, 2026 15:08
@JulianMaurin @claude
fix(cli): render stack-squash validation errors via clap
1fecbbb 
Route `stack squash` argument validation through `clap::Error`
(ValueValidation) so failures render with the usage line and the
standard exit code, like other parse errors, instead of a bare
`eprintln!` + `exit(2)`.

Also correct the `--debug` dispatch comment: the flag is consumed by
`init_tracing()` at startup, not by command impls.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I86663735cc017dca638ff66ae0336d1e6d7b1b31
@JulianMaurin @claude
feat(install): print how to enable shell completions
f05dac8 
After dropping the binary, print the exact command to enable tab
completion for the detected shell ($SHELL): bash, zsh, and fish each
get a ready-to-paste line; any other shell is pointed at `mergify
completions`. The installer writes nothing into the user's shell dirs.

A curl|sh installer that ships a single binary leaves shell config to
the user, as rustup and starship do; writing completion files from it
is both surprising and unreliable — ~/.zfunc is off zsh's $fpath by
default. Man-page generation stays available via the binary for real
packaging.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I9231ed40b44e96dc68f216f6820581cb71bfa579
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/print-enable-shell-completions--9231ed40 branch from 2363101 to f05dac8 Compare June 23, 2026 13:08
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735 branch from cbbb1dd to 1fecbbb Compare June 23, 2026 13:08
@JulianMaurin JulianMaurin mentioned this pull request Jun 23, 2026
Merged
@mergify mergify Bot deployed to Mergify Merge Protections June 23, 2026 13:09 Active
kozlek
kozlek previously approved these changes Jun 23, 2026
View reviewed changes
@mergify mergify Bot requested a review from a team June 23, 2026 13:14
@kozlek

kozlek commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@Mergifyio queue

@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-06-23 18:53 UTC · Rule: default · triggered by the @mergifyio queue command
  • ✅ Checks skipped · PR is already up-to-date
  • 🚫 Left the queue — 2026-06-23 19:02 UTC · at f05dac8444ded7f3b9a75d5e4bdb2922572adc57

This pull request spent 8 minutes 21 seconds in the queue, including 6 minutes 48 seconds running CI.

Waiting for
All conditions

Reason

Pull request #1675 has been dequeued

Queue conditions are not satisfied:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

This was referenced Jun 23, 2026
Merged
Merged
Merged
This was referenced Jun 23, 2026
Merged
Merged
Merged
jd
jd previously approved these changes Jun 23, 2026
View reviewed changes
@mergify mergify Bot added the queued label Jun 23, 2026
@mergify mergify Bot mentioned this pull request Jun 23, 2026
Closed
38 tasks
@mergify mergify Bot added dequeued and removed queued labels Jun 23, 2026
@mergify

mergify Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 7 minutes 7 seconds in the queue, including 12 minutes 31 seconds running CI.

Waiting for
  • #approved-reviews-by>=2
All conditions

Reason

Pull request #1675 has been dequeued

merge conditions no longer match. Blocked by:

  • #approved-reviews-by>=2

  • author = dependabot[bot]

  • author = mergify-ci-bot

  • author = renovate[bot]

  • all of [🛡 Merge Protections rule 👀 Review Requirements]:

    • any of:
      • #approved-reviews-by>=2
      • author = dependabot[bot]
      • author = mergify-ci-bot
      • author = renovate[bot]

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

@mergify mergify Bot added queued and removed dequeued labels Jun 25, 2026
@mergify mergify Bot mentioned this pull request Jun 25, 2026
Closed
38 tasks
Base automatically changed from devs/JulianMaurin/feat/rust-cli-excellence/render-stack-squash-val-errors-via-clap--86663735 to main June 25, 2026 05:47
@mergify mergify Bot dismissed stale reviews from jd and kozlek June 25, 2026 05:47

The base branch was changed.

@mergify mergify Bot requested a review from a team June 25, 2026 05:47
@mergify mergify Bot added dequeued and removed queued labels Jun 25, 2026
@mergify mergify Bot requested a review from a team June 25, 2026 06:47
@JulianMaurin

JulianMaurin commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify

mergify Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 7 minutes 12 seconds in the queue, including 6 minutes 42 seconds running CI.

Required conditions to merge

@mergify mergify Bot added queued and removed dequeued labels Jun 25, 2026
@mergify mergify Bot mentioned this pull request Jun 25, 2026
Closed
38 tasks
@mergify mergify Bot merged commit c6bfedc into main Jun 25, 2026
22 of 42 checks passed
@mergify mergify Bot deleted the devs/JulianMaurin/feat/rust-cli-excellence/print-enable-shell-completions--9231ed40 branch June 25, 2026 07:46
@mergify mergify Bot removed the queued label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jd jd jd approved these changes
@kozlek kozlek kozlek approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JulianMaurin @kozlek @jd