Skip to content

refactor: dedupe the GIT_SEQUENCE_EDITOR lookup and drop port cruft#1660

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/dedupe-git-sequence-editor-lookup-drop-port-cruft--22a6f292
Jun 23, 2026
Merged

refactor: dedupe the GIT_SEQUENCE_EDITOR lookup and drop port cruft#1660
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/dedupe-git-sequence-editor-lookup-drop-port-cruft--22a6f292

Conversation

@JulianMaurin

@JulianMaurin JulianMaurin commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

run_native resolved the running binary's path with the same
eight-line std::env::current_exe().map_err(…) block copy-pasted
eight times across the rebase-family stack arms. Extract it into
mergify_self_exe(), which also preserves the underlying I/O error as
a caused by: source via CliError::wrap.

Drop the leftover Python-port narration: the stack new "the rest
still shim to Python" doc, and push.rs's "Python uses asyncio fan-out"
comments. Restate push's design positively — async is incidental
(reqwest's client is async-only); upserts run sequentially because
Depends-On needs the predecessor's PR number and stacks are small.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@JulianMaurin JulianMaurin mentioned this pull request Jun 19, 2026
Merged
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 19, 2026 07:11 Failure
@JulianMaurin JulianMaurin mentioned this pull request Jun 19, 2026
Merged
This was referenced Jun 19, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mergify

mergify Bot commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 6 merge protections satisfied — ready to merge.

Show 6 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

This was referenced Jun 19, 2026
Merged
Merged
@JulianMaurin

JulianMaurin commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 refactor: dedupe the GIT_SEQUENCE_EDITOR lookup and drop port cruft #1660 👈
2 docs(agents): rewrite AGENTS.md for the Rust workspace #1661
3 fix(cli): render stack-squash validation errors via clap #1671
4 feat(install): print how to enable shell completions #1675

@JulianMaurin JulianMaurin mentioned this pull request Jun 19, 2026
Merged
@JulianMaurin JulianMaurin marked this pull request as ready for review June 19, 2026 07:13
@mergify mergify Bot requested a review from a team June 19, 2026 07:19
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/dedupe-git-sequence-editor-lookup-drop-port-cruft--22a6f292 branch from 8e22fe5 to e600168 Compare June 19, 2026 07:52
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 8ead627 to 4e826a7 Compare June 19, 2026 07:52
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 19, 2026 07:52 Failure
@JulianMaurin

JulianMaurin commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Revision history

# Type Changes Reason Date
1 initial 8e22fe5 2026-06-19 07:52 UTC
2 rebase 8e22fe5 → e600168 (rebase only) 2026-06-19 07:52 UTC
3 rebase e600168 → 68a295f (rebase only) 2026-06-19 16:51 UTC
4 rebase 68a295f → 7eafe8a (rebase only) 2026-06-22 09:10 UTC
5 rebase 7eafe8a → dc63528 (rebase only) 2026-06-22 09:15 UTC
6 rebase dc63528 → a5927b8 (rebase only) 2026-06-22 13:00 UTC
7 rebase a5927b8 → e74d392 (rebase only) 2026-06-23 07:41 UTC
8 rebase e74d392 → b2ac905 (rebase only) 2026-06-23 09:11 UTC
9 rebase b2ac905 → d41fe95 (rebase only) 2026-06-23 12:10 UTC

@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/dedupe-git-sequence-editor-lookup-drop-port-cruft--22a6f292 branch from e600168 to 68a295f Compare June 19, 2026 16:51
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 19, 2026 16:51 Failure
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 10d5ea0 to c655221 Compare June 22, 2026 09:10
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 22, 2026 13:01 Failure
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/dedupe-git-sequence-editor-lookup-drop-port-cruft--22a6f292 branch from a5927b8 to e74d392 Compare June 23, 2026 07:41
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 902b96f to b47a14c Compare June 23, 2026 07:41
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 23, 2026 07:41 Failure
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/dedupe-git-sequence-editor-lookup-drop-port-cruft--22a6f292 branch from e74d392 to b2ac905 Compare June 23, 2026 09:11
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from b47a14c to 793f601 Compare June 23, 2026 09:11
@mergify mergify Bot had a problem deploying to Mergify Merge Protections June 23, 2026 09:12 Failure
@JulianMaurin JulianMaurin mentioned this pull request Jun 23, 2026
Closed
@mergify mergify Bot force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 793f601 to d051fab Compare June 23, 2026 09:31
Base automatically changed from devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f to main June 23, 2026 09:45
@JulianMaurin @claude
refactor: dedupe the GIT_SEQUENCE_EDITOR lookup and drop port cruft
d41fe95 
`run_native` resolved the running binary's path with the same
eight-line `std::env::current_exe().map_err(…)` block copy-pasted
eight times across the rebase-family stack arms. Extract it into
`mergify_self_exe()`, which also preserves the underlying I/O error as
a `caused by:` source via `CliError::wrap`.

Drop the leftover Python-port narration: the `stack new` "the rest
still shim to Python" doc, and push.rs's "Python uses asyncio fan-out"
comments. Restate push's design positively — async is incidental
(reqwest's client is async-only); upserts run sequentially because
Depends-On needs the predecessor's PR number and stacks are small.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I22a6f2928524ae6d1f5924063a8b7956000b8d3a
@JulianMaurin JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/dedupe-git-sequence-editor-lookup-drop-port-cruft--22a6f292 branch from b2ac905 to d41fe95 Compare June 23, 2026 12:10
@JulianMaurin JulianMaurin mentioned this pull request Jun 23, 2026
Merged
@mergify mergify Bot deployed to Mergify Merge Protections June 23, 2026 12:10 Active
@mergify mergify Bot requested a review from a team June 23, 2026 12:20
@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-06-23 12:33 UTC · Rule: default · triggered by merge protections
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-06-23 12:33 UTC · at d41fe95a70cd3fe353d9781e9f16e296ecf4487f · squash

This pull request spent 42 seconds in the queue, including 8 seconds running CI.

Required conditions to merge

@mergify mergify Bot merged commit 495b5ed into main Jun 23, 2026
22 of 42 checks passed
@mergify mergify Bot added the queued label Jun 23, 2026
@mergify mergify Bot deleted the devs/JulianMaurin/feat/rust-cli-excellence/dedupe-git-sequence-editor-lookup-drop-port-cruft--22a6f292 branch June 23, 2026 12:33
@mergify mergify Bot removed the queued label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kozlek kozlek kozlek approved these changes
@remyduthu remyduthu remyduthu approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JulianMaurin @kozlek @remyduthu