Skip to content

test: golden-snapshot the CLI surface and guard schema drift#1659

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f
Jun 23, 2026
Merged

test: golden-snapshot the CLI surface and guard schema drift#1659
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f

Conversation

@JulianMaurin

Copy link
Copy Markdown
Contributor

The CLI's contract (every flag, subcommand, value-hint, help string,
exit code) was only spot-checked structurally, so a dropped flag or
renamed leaf could regress unnoticed.

Add an insta JSON golden of the full generated schema (version
redacted, since it's release-stamped) — intentional CLI changes are
accepted with cargo insta review, accidental drift shows as a red
diff. Also assert directly that the stack subcommands in the schema
equal the NATIVE_COMMANDS registry, closing the two-list drift that
the old shim allowed (a deleted leaf used to vanish silently).

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Depends-On: #1658

@mergify

mergify Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 ⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

🟢 🤖 Continuous Integration

  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@JulianMaurin

JulianMaurin commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 feat(cli): generate shell completions and a man page #1658
2 test: golden-snapshot the CLI surface and guard schema drift #1659 👈
3 refactor: dedupe the GIT_SEQUENCE_EDITOR lookup and drop port cruft #1660
4 docs(agents): rewrite AGENTS.md for the Rust workspace #1661
5 fix(cli): render stack-squash validation errors via clap #1671
6 feat(install): drop completions and a man page during install #1674

@JulianMaurin
JulianMaurin marked this pull request as ready for review June 19, 2026 07:13
@mergify
mergify Bot requested a review from a team June 19, 2026 07:18
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b branch from 6d9065b to 403899f Compare June 19, 2026 07:52
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 8ead627 to 4e826a7 Compare June 19, 2026 07:52
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections June 19, 2026 07:52 Failure
@JulianMaurin

JulianMaurin commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Revision history

# Type Changes Reason Date
1 initial 8ead627 2026-06-19 07:52 UTC
2 rebase 8ead627 → 4e826a7 (rebase only) 2026-06-19 07:52 UTC
3 content 4e826a7 → 10d5ea0 (raw) 2026-06-19 16:51 UTC
4 content 10d5ea0 → c655221 (raw) Regenerate the CLI schema snapshot: the local --verbose entries on stack list and queue show were dropped when unified onto the global flag. 2026-06-22 09:10 UTC
5 rebase c655221 → 2350cd3 (rebase only) 2026-06-22 09:15 UTC
6 rebase 2350cd3 → 902b96f (rebase only) 2026-06-22 13:00 UTC
7 rebase 902b96f → b47a14c (rebase only) 2026-06-23 07:41 UTC
8 rebase b47a14c → 793f601 (rebase only) 2026-06-23 09:11 UTC

@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b branch from 403899f to 2d93dbb Compare June 19, 2026 16:51
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 4e826a7 to 10d5ea0 Compare June 19, 2026 16:51
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 2350cd3 to 902b96f Compare June 22, 2026 13:00
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b branch from 1b380ea to 4c2d1ce Compare June 22, 2026 13:00
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections June 22, 2026 13:01 Failure
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 902b96f to b47a14c Compare June 23, 2026 07:41
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b branch from 4c2d1ce to 9a7d375 Compare June 23, 2026 07:41
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections June 23, 2026 07:41 Failure
The CLI's contract (every flag, subcommand, value-hint, help string,
exit code) was only spot-checked structurally, so a dropped flag or
renamed leaf could regress unnoticed.

Add an `insta` JSON golden of the full generated schema (version
redacted, since it's release-stamped) — intentional CLI changes are
accepted with `cargo insta review`, accidental drift shows as a red
diff. Also assert directly that the stack subcommands in the schema
equal the `NATIVE_COMMANDS` registry, closing the two-list drift that
the old shim allowed (a deleted leaf used to vanish silently).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I25a9400f84da784eba19583965376de221ed5370
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b branch from 9a7d375 to eb00a9a Compare June 23, 2026 09:11
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from b47a14c to 793f601 Compare June 23, 2026 09:11
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections June 23, 2026 09:12 Failure
Base automatically changed from devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b to main June 23, 2026 09:30
@mergify
mergify Bot force-pushed the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch from 793f601 to d051fab Compare June 23, 2026 09:31
@mergify
mergify Bot temporarily deployed to func-tests-live June 23, 2026 09:31 Inactive
@mergify
mergify Bot deployed to Mergify Merge Protections June 23, 2026 09:31 Active
@mergify
mergify Bot requested a review from a team June 23, 2026 09:37
@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-06-23 09:44 UTC · Rule: default · triggered by merge protections
  • Checks skipped · PR is already up-to-date
  • Merged2026-06-23 09:45 UTC · at d051fabbf59a19e3b53312395889ba345e34c517 · squash

This pull request spent 34 seconds in the queue, including 7 seconds running CI.

Required conditions to merge

@mergify
mergify Bot merged commit 341053f into main Jun 23, 2026
22 checks passed
@mergify mergify Bot added the queued label Jun 23, 2026
@mergify
mergify Bot deleted the devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f branch June 23, 2026 09:45
@mergify mergify Bot removed the queued label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants