test: golden-snapshot the CLI surface and guard schema drift#1659
Merged
Conversation
JulianMaurin
had a problem deploying
to
func-tests-live
June 19, 2026 07:11 — with
GitHub Actions
Failure
This was referenced Jun 19, 2026
Contributor
Merge Protections🟢 All 7 merge protections satisfied — ready to merge. Show 7 satisfied protections🟢 ⛓️ Depends-On RequirementsRequirement based on the presence of
🟢 🤖 Continuous Integration
🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
Contributor
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Jun 19, 2026
JulianMaurin
marked this pull request as ready for review
June 19, 2026 07:13
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b
branch
from
June 19, 2026 07:52
6d9065b to
403899f
Compare
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f
branch
from
June 19, 2026 07:52
8ead627 to
4e826a7
Compare
JulianMaurin
had a problem deploying
to
func-tests-live
June 19, 2026 07:52 — with
GitHub Actions
Error
JulianMaurin
had a problem deploying
to
func-tests-live
June 19, 2026 07:52 — with
GitHub Actions
Failure
Contributor
Author
Revision history
|
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b
branch
from
June 19, 2026 16:51
403899f to
2d93dbb
Compare
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f
branch
from
June 19, 2026 16:51
4e826a7 to
10d5ea0
Compare
JulianMaurin
had a problem deploying
to
func-tests-live
June 19, 2026 16:51 — with
GitHub Actions
Error
JulianMaurin
had a problem deploying
to
func-tests-live
June 19, 2026 16:51 — with
GitHub Actions
Failure
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f
branch
from
June 22, 2026 13:00
2350cd3 to
902b96f
Compare
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b
branch
from
June 22, 2026 13:00
1b380ea to
4c2d1ce
Compare
JulianMaurin
had a problem deploying
to
func-tests-live
June 22, 2026 13:00 — with
GitHub Actions
Error
JulianMaurin
temporarily deployed
to
func-tests-live
June 22, 2026 13:00 — with
GitHub Actions
Inactive
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f
branch
from
June 23, 2026 07:41
902b96f to
b47a14c
Compare
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b
branch
from
June 23, 2026 07:41
4c2d1ce to
9a7d375
Compare
JulianMaurin
had a problem deploying
to
func-tests-live
June 23, 2026 07:41 — with
GitHub Actions
Error
JulianMaurin
temporarily deployed
to
func-tests-live
June 23, 2026 07:41 — with
GitHub Actions
Inactive
The CLI's contract (every flag, subcommand, value-hint, help string, exit code) was only spot-checked structurally, so a dropped flag or renamed leaf could regress unnoticed. Add an `insta` JSON golden of the full generated schema (version redacted, since it's release-stamped) — intentional CLI changes are accepted with `cargo insta review`, accidental drift shows as a red diff. Also assert directly that the stack subcommands in the schema equal the `NATIVE_COMMANDS` registry, closing the two-list drift that the old shim allowed (a deleted leaf used to vanish silently). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Change-Id: I25a9400f84da784eba19583965376de221ed5370
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b
branch
from
June 23, 2026 09:11
9a7d375 to
eb00a9a
Compare
JulianMaurin
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f
branch
from
June 23, 2026 09:11
b47a14c to
793f601
Compare
JulianMaurin
had a problem deploying
to
func-tests-live
June 23, 2026 09:11 — with
GitHub Actions
Error
JulianMaurin
temporarily deployed
to
func-tests-live
June 23, 2026 09:11 — with
GitHub Actions
Inactive
Base automatically changed from
devs/JulianMaurin/feat/rust-cli-excellence/generate-shell-completions-man-page--4c27238b
to
main
June 23, 2026 09:30
mergify
Bot
force-pushed
the
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f
branch
from
June 23, 2026 09:31
793f601 to
d051fab
Compare
jd
approved these changes
Jun 23, 2026
kozlek
approved these changes
Jun 23, 2026
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 34 seconds in the queue, including 7 seconds running CI. Required conditions to merge
|
mergify
Bot
deleted the
devs/JulianMaurin/feat/rust-cli-excellence/golden-snapshot-cli-surface-guard-schema-drift--25a9400f
branch
June 23, 2026 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI's contract (every flag, subcommand, value-hint, help string,
exit code) was only spot-checked structurally, so a dropped flag or
renamed leaf could regress unnoticed.
Add an
instaJSON golden of the full generated schema (versionredacted, since it's release-stamped) — intentional CLI changes are
accepted with
cargo insta review, accidental drift shows as a reddiff. Also assert directly that the stack subcommands in the schema
equal the
NATIVE_COMMANDSregistry, closing the two-list drift thatthe old shim allowed (a deleted leaf used to vanish silently).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Depends-On: #1658