merge queue: queuing main (e7960d7), #1671 and #1675 together#1688
Closed
mergify[bot] wants to merge 4 commits into
Closed
merge queue: queuing main (e7960d7), #1671 and #1675 together#1688mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
Route `stack squash` argument validation through `clap::Error` (ValueValidation) so failures render with the usage line and the standard exit code, like other parse errors, instead of a bare `eprintln!` + `exit(2)`. Also correct the `--debug` dispatch comment: the flag is consumed by `init_tracing()` at startup, not by command impls. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Change-Id: I86663735cc017dca638ff66ae0336d1e6d7b1b31
After dropping the binary, print the exact command to enable tab completion for the detected shell ($SHELL): bash, zsh, and fish each get a ready-to-paste line; any other shell is pointed at `mergify completions`. The installer writes nothing into the user's shell dirs. A curl|sh installer that ships a single binary leaves shell config to the user, as rustup and starship do; writing completion files from it is both surprising and unreliable — ~/.zfunc is off zsh's $fpath by default. Man-page generation stays available via the binary for real packaging. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Change-Id: I9231ed40b44e96dc68f216f6820581cb71bfa579
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (e7960d7), #1671 and #1675 are queued together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #1675.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:depends-on=Mergifyio/mergify-cli#1671[⛓️ fix(cli): render stack-squash validation errors via clap #1671 [stack]]Enforce conventional commit]:title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:👀 Review Requirements]:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=ci-gateRequired conditions to stay in the queue:
base=maindepends-on=Mergifyio/mergify-cli#1671[⛓️ fix(cli): render stack-squash validation errors via clap #1671 [stack]]label!=manual mergeEnforce conventional commit]:title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:👀 Review Requirements]:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=ci-gate