Skip to content

fix(isVAT): validate the RO check digit #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vicuts wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(isVAT): validate the RO check digit #2900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbd2e47
fix(isVAT): validate the RO check digit
vicuts Oct 4, 2026
e91b82e
test(isVAT): cover the RO check digit remainder of 10
vicuts Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/lib/isVAT.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,22 @@ const PT = (str) => {
return checksum === parseInt(tin[8], 10);
};

const RO = (str) => {
const match = str.match(/^(RO)?(\d{2,10})$/);
if (!match) {
return false;
}

// @see {@link https://ro.wikipedia.org/wiki/Cod_de_identificare_fiscal%C4%83}
const digits = match[2].split('').map(a => parseInt(a, 10));
const checkDigit = digits.pop();
// Shorter codes are left-padded with zeros, so they use the last weights
const weights = [7, 5, 3, 2, 1, 7, 5, 3, 2].slice(-digits.length);
const sum = digits.reduce((acc, digit, idx) => acc + (digit * weights[idx]), 0);
const remainder = (sum * 10) % 11;
return (remainder === 10 ? 0 : remainder) === checkDigit;
};

export const vatMatchers = {
/**
* European Union VAT identification numbers
Expand All @@ -73,7 +89,7 @@ export const vatMatchers = {
NL: str => /^(NL)?\d{9}B\d{2}$/.test(str),
PL: str => /^(PL)?(\d{10}|(\d{3}-\d{3}-\d{2}-\d{2})|(\d{3}-\d{2}-\d{2}-\d{3}))$/.test(str),
PT,
RO: str => /^(RO)?\d{2,10}$/.test(str),
RO,
SK: str => /^(SK)?\d{10}$/.test(str),
SI: str => /^(SI)?\d{8}$/.test(str),
ES: str => /^(ES)?(?:[ABEH]\d{8}|[NPQRSW]\d{7}[A-J]|[CDFGJUV]\d{7}[0-9A-J])$/.test(str),
Expand Down
20 changes: 16 additions & 4 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15536,14 +15536,26 @@ describe('Validators', () => {
validator: 'isVAT',
args: ['RO'],
valid: [
'RO14399840',
'14399840',
'RO2816464',
'2816464',
'RO1234567897',
'RO19',
'19',
'RO10000130',
'60',
],
invalid: [
'RO 14399840',
'RO14399841',
'2816465',
'RO1234567890',
'1234567890',
'RO12',
'12',
],
invalid: [
'RO 12',
'61',
'1',
'12345678975',
],
});
test({
Expand Down
Loading