Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2900 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2608 +9
Branches 658 660 +2
=========================================
+ Hits 2599 2608 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isVAT(str, 'RO')only checked that the code has 2 to 10 digits, so any number of that length passed, including codes with a wrong check digit.Romanian VAT numbers (CUI/CIF) end in a check digit. This adds the standard check, in the same style as the existing
AU,CHandPTmatchers:753217532and add the products.The previous valid examples
1234567890and12have wrong check digits, so they move to the invalid list. RO codes with a wrong check digit that passed before are now rejected, which is the intended fix.References
753217532and works through14399840, which is now one of the valid test cases.Checklist
ROis already listed forisVATand the API is the same