Match the build-time helm binary to the linked helm library - #5213
Merged
dimitri-nicolo merged 1 commit intoAug 18, 2026
Merged
Conversation
HELM3_VERSION = v3.21.1 -> v3.21.3 This is the helm program hack/bin downloads to pull the Envoy Gateway chart during a build. It is a build tool and never ships in the operator image, separate from the helm.sh/helm/v3 library the operator links -- which is on v3.21.3, one patch ahead of the binary. Nothing committed changes. The binary's only job here is `helm pull` of an OCI artifact, and the chart tarball it lands is gitignored (`*.tgz`), fetched fresh on each build and rendered at runtime by the library. An OCI pull is content-addressed, so the artifact is identical whichever helm version fetches it. Noticed while answering the same question on release-v1.41, where the binary had been left on v3.11.3. Both release-v1.42 and release-v1.40 are still on v3.11.3 against library v3.21.3 and get the same change separately -- this commit does not cherry-pick to them, because they still `helm template` the chart into a committed resources file rather than pulling it, so their version of this bump also regenerates that file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the build-time Helm binary version downloaded into hack/bin so it matches the Helm Go library version already linked by the operator (helm.sh/helm/v3 v3.21.3). This keeps the build toolchain consistent without affecting shipped artifacts.
Changes:
- Bump
HELM3_VERSIONin the build tooling fromv3.21.1tov3.21.3. - Aligns the build-time Helm binary with the already-used Helm library version (
helm.sh/helm/v3 v3.21.3).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dimitri-nicolo
added
docs-not-required
release-note-not-required
and removed
docs-pr-required
labels
pasanw
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HELM3_VERSIONv3.21.1 → v3.21.3This is the helm program
hack/bindownloads during a build. It's a build tool — it never ships in the operator image — and it's separate from thehelm.sh/helm/v3library the operator links, which is on v3.21.3. The binary was one patch behind it.Nothing committed changes
On master the binary's only job is
helm pullof an OCI artifact, and the chart tarball it lands is gitignored (*.tgz), fetched fresh each build and rendered at runtime by the library. An OCI pull is content-addressed, so the artifact is identical whichever helm version fetches it. The diff is one line.Context
Noticed while answering a review comment on #5176, where this binary had been left on v3.11.3 — a 2021 release — on
release-v1.41.The other branches are worse off than master and get the same change separately:
This commit does not cherry-pick to those branches: they still
helm templatethe chart into a committedgateway_api_resources.yamlrather than pulling it, so their version of the bump also regenerates that file. I verified the pick conflicts rather than assuming it.Release note: