Match the build-time helm binary to the linked helm library (release-v1.42) - #5214
Merged
dimitri-nicolo merged 1 commit intoAug 18, 2026
Conversation
HELM3_VERSION = v3.11.3 -> v3.21.3
This is the helm program hack/bin downloads to render the Envoy Gateway chart
into pkg/render/gatewayapi/gateway_api_resources.yaml at build time. It is a
build tool and never ships in the operator image, separate from the
helm.sh/helm/v3 library the operator links -- which is already on v3.21.3
while the binary sat ten minors behind on a 2021 release.
The regenerated resources file is committed alongside, because the make rule
keys off the versioned binary name and would otherwise re-render it and fail
dirty-check.
The upgrade is inert in the way that matters. Across 58,298 lines the only
change is nine comment lines, where helm now records the full chart path in
the source comment:
-# Source: crds/gatewayapi-crds.yaml
+# Source: gateway-helm/charts/crds/crds/gatewayapi-crds.yaml
No Kubernetes resource changes -- not a field, not an ordering, not a
generated label. The nine lines are YAML comments, dropped at parse time.
Verified:
- v3.11.3 re-renders the committed file byte for byte, so the comparison is
against a faithful baseline rather than a drifted one
- `git diff` on the regenerated file touches only `# Source:` lines
- go test ./pkg/render/gatewayapi/... passes
master gets the same bump separately rather than by cherry-pick: it pulls the
chart tarball instead of templating it, so its commit carries no resources
file and its Makefile line reads v3.21.1. release-v1.40 takes this commit as
a clean cherry-pick.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the build-time Helm CLI version used by the Makefile to match the already-upgraded linked helm.sh/helm/v3 Go library version, and regenerates the committed Envoy Gateway rendered resources so builds remain reproducible/clean.
Changes:
- Bump
HELM3_VERSIONfromv3.11.3tov3.21.3for the build-time Helm binary download. - Regenerate
pkg/render/gatewayapi/gateway_api_resources.yaml, with changes limited to# Source:comment lines (no resource content changes).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Updates the build-time Helm binary version used to render Envoy Gateway resources. |
| pkg/render/gatewayapi/gateway_api_resources.yaml | Re-rendered output committed to keep builds clean; only # Source: comment paths change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dimitri-nicolo
added
docs-not-required
release-note-not-required
and removed
docs-pr-required
labels
pasanw
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HELM3_VERSIONv3.11.3 → v3.21.3This is the helm program
hack/bindownloads to render the Envoy Gateway chart intopkg/render/gatewayapi/gateway_api_resources.yamlat build time. It's a build tool — it never ships in the operator image — and it's separate from thehelm.sh/helm/v3library the operator links, which is already on v3.21.3. The binary had been left on a 2021 release, ten minors behind.The regenerated resources file is committed alongside, because the make rule keys off the versioned binary name and would otherwise re-render it and fail
dirty-check.The upgrade is inert
Across 58,298 lines the only change is nine comment lines, where helm now records the full chart path in the source comment:
No Kubernetes resource changes — not a field, not an ordering, not a generated label. Those nine lines are YAML comments, dropped at parse time.
Verified
git diffon the regenerated file touches only# Source:lines.go test ./pkg/render/gatewayapi/...passes.Context
Noticed while answering a review comment on #5176. master gets the same bump separately (#5213) rather than by cherry-pick — it pulls the chart tarball instead of templating it, so its commit carries no resources file.
release-v1.40takes this commit as a clean cherry-pick; see its companion PR.Release note: