Repository navigation
[SDK-764] Allow rollbar 4.x as a peer dependency - #174
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
@rollbar/react@1.1.0, the latest on npm, declares a rollbar peer range of "^2.26.4 || ^3.0.0-alpha.3", so npm install in the React examples fails with ERESOLVE against rollbar 4.0.0. That broke Validate examples and Build example apps for browser tests on every CI leg. Override @rollbar/react's rollbar dependency to the example's own rollbar ($rollbar, i.e. the local tarball) so npm resolves a single rollbar@4.0.0. The real fix is rollbar/rollbar-react#174 plus a new @rollbar/react release; these overrides can be dropped once that ships. Linear: SDK-764 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI Agent Review LGTM (openai, openai-astra)LGTM. No blocking findings were found. Review: allow rollbar 4.x as a peer dependencyThe change is small and consistent with itself. How this package touches the peer:
Not verified (no findings raised): the installed rollbar is 3.1.0 ( Test coverage note: nothing in this repo runs against rollbar 4.x:
The typecheck, unit tests and example tests therefore still run only against 3.x, and the 4.x support this PR advertises isn't checked automatically. Consider bumping the devDependency to 4.x, or adding a CI job that installs This PR doesn't show whether any tests passed. |
Description of the change
Adds
^4.0.0to therollbarpeer dependency range, inpackage.jsonand in the root package entry ofpackage-lock.json. Same shape as #132, which added 3.x.rollbar.js 4.0.0 is being prepared in rollbar/rollbar.js#1505. Its only breaking change is dropping Node 18 support (rollbar/rollbar.js#1481). Nothing in the browser/React API this package uses changes. Under the current range, npm 7+ rejects
rollbar@4alongside@rollbar/react@1.1.0withERESOLVE. That rejection also fails the React examples in rollbar.js's own CI on the release PR.The
rollbardevDependency stays at^3.1.0because 4.0.0 isn't on npm yet. It can move once rollbar.js publishes. Users only get the wider range when a new@rollbar/reactis published; this PR doesn't bump the version.Type of change
Related issues
Validation
npm ciwith the updated lockfile succeeds on Node 24 / npm 11, so the lockfile is consistent.npm test: 13/13 pass.npm run lintandnpm run buildare clean.semver.satisfiesagainst the new range: 2.26.4, 3.1.0, 4.0.0 and 4.3.2 are accepted; 2.26.3 and 5.0.0 are rejected.react@18,prop-typesand the rollbar 4.0.0 tarball built from Release 4.0.0 rollbar.js#1505:@rollbar/react@1.1.0from npm fails withERESOLVE ... peer rollbar@"^2.26.4 || ^3.0.0-alpha.3".npm pack, installs cleanly and resolvesrollbar@4.0.0.Checklists
Development
🤖 Generated with Claude Code