Skip to content

Send TextInput color when props diffing is enabled - #60072

Open
coado wants to merge 1 commit into
coado/textinput-diffing-01-eventsfrom
coado/textinput-diffing-02-color
Open

coado wants to merge 1 commit into
coado/textinput-diffing-01-eventsfrom
coado/textinput-diffing-02-color

Conversation

@coado

@coado coado commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Fixes the issue of not sending TextInput color value to the platform when the props 2.0 are enabled. The change reads color from the textAttributes.foregroundColor because it is parsed into that field in the BaseTextProps, so it doesn't reintroduce #58093.

Changelog:

[Internal] - Fix sending TextInput color prop value when props 2.0 are enabled.

Test Plan:

Added new AndroidTextInputPropsDiffTest.

Stack:

🤖 Generated with Claude Code

Summary:
`AndroidTextInputProps::getDiffProps` never sent `color`. The flat `color` field is not parsed, so the value is only available in `textAttributes.foregroundColor`. Existing text is colored by the attributed string in the state, but the native view kept its default text color, so text typed into an empty input ignored `color`. With a light `color` on a dark background the typed text was black.

This sends `color` from the text attributes, and `null` when it is removed so that `ReactTextInputManager` restores the default text color.

TextInput doesn't use props diffing yet: `getDiffPropsImplementationTarget()` returns `TextInput`, which doesn't match the `AndroidTextInput` component name. So the problem above only appears once that is enabled, and this change has no runtime effect until then.

Changelog:
[Internal] - Send TextInput color when props diffing is enabled

Test Plan:
`AndroidTextInputPropsDiffTest.colorIsSent` compares the props diffing payload with the raw props payload. It fails without this change and passes with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants