Skip to content

Send TextInput event props when props diffing is enabled - #60071

Open
coado wants to merge 1 commit into
mainfrom
coado/textinput-diffing-01-events
Open

coado wants to merge 1 commit into
mainfrom
coado/textinput-diffing-01-events

Conversation

@coado

@coado coado commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

ReactTextInputManager only sets up the watchers behind onKeyPress, onSelectionChange, onContentSizeChange and onScroll once it receives the matching prop. AndroidTextInputProps had no fields for these props, so getDiffProps never sent them and the events never fired with props diffing on. TextInput.js always passes onScroll and onSelectionChange, so every TextInput would be affected.

The problem above appears when the enablePropsUpdateReconciliationAndroid flag is enabled.

Changelog:

[Internal] - Send TextInput event props when props diffing is enabled

Test Plan:

AndroidTextInputPropsDiffTest.eventHandlerPropsAreSent compares the props diffing payload with the raw props payload. It fails without this change and passes with it. python -m scripts.cxx-api.parser --validate passes at this commit.

Stack:

🤖 Generated with Claude Code

Summary:
`ReactTextInputManager` only sets up the watchers behind `onKeyPress`, `onSelectionChange`, `onContentSizeChange` and `onScroll` once it receives the matching prop. `AndroidTextInputProps` had no fields for these props, so `getDiffProps` never sent them and the events never fired with props diffing on. `TextInput.js` always passes `onScroll` and `onSelectionChange`, so every TextInput would be affected.

This adds the fields and sends them. JS sends a handler as `true`. Removing a handler sends `false`, which the setters treat the same as the `null` sent by raw props.

TextInput doesn't use props diffing yet: `getDiffPropsImplementationTarget()` returns `TextInput`, which doesn't match the `AndroidTextInput` component name. So the problem above only appears once that is enabled, and this change has no runtime effect until then.

Changelog:
[Internal] - Send TextInput event props when props diffing is enabled

Test Plan:
`AndroidTextInputPropsDiffTest.eventHandlerPropsAreSent` compares the props diffing payload with the raw props payload. It fails without this change and passes with it. `python -m scripts.cxx-api.parser --validate` passes at this commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment on lines +116 to +119
bool onKeyPress{false};
bool onSelectionChange{false};
bool onContentSizeChange{false};
bool onScroll{false};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these serve the same purpose as the props below. Why not match the naming pattern (hasOnKeyPress...)?

Unless I'm wrong here.

Comment on lines +116 to +118
bool onKeyPress{false};
bool onSelectionChange{false};
bool onContentSizeChange{false};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each bool will take up a byte here - use something like ViewEvents to flatten it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants