Repository navigation
Name the right env var in Fantom's heap snapshot error - #60065
Merged
meta-codesync[bot] merged 1 commit intoNov 17, 2026
Merged
meta-codesync[bot] merged 1 commit into
meta-codesync[bot] merged 1 commit into
Conversation
javache
approved these changes
Nov 17, 2026
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D132533350. |
Collaborator
|
This pull request was successfully merged by @lazerg in 4ceced9 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When a JS heap snapshot fails because Hermes has no memory instrumentation,
takeJSMemoryHeapSnapshottells you to run Fantom withFANTOM_ENABLE_MEMORY_INSTRUMENTATION=1. Fantom readsFANTOM_ENABLE_JS_MEMORY_INSTRUMENTATION, and global setup rejects any otherFANTOM_variable, so following the hint stops the run with "Unexpected Fantom environment variable". This makes the message name the variable Fantom actually reads.Fixes #60063
Changelog:
[INTERNAL] [FIXED] - Name the right env var in Fantom's heap snapshot error
Test Plan:
Ran the Fantom Jest config with
FANTOM_ENABLE_MEMORY_INSTRUMENTATION=1: global setup throws "Unexpected Fantom environment variable". WithFANTOM_ENABLE_JS_MEMORY_INSTRUMENTATION=1it gets past validation and stops on the expected "Memory instrumentation is not supported in CI or OSS environments" check, so the new hint points at the accepted variable. Message-only change.