Repository navigation
Commit 4ceced9
authored
Name the right env var in Fantom's heap snapshot error
## Summary:
When a JS heap snapshot fails because Hermes has no memory instrumentation, `takeJSMemoryHeapSnapshot` tells you to run Fantom with `FANTOM_ENABLE_MEMORY_INSTRUMENTATION=1`. Fantom reads `FANTOM_ENABLE_JS_MEMORY_INSTRUMENTATION`, and global setup rejects any other `FANTOM_` variable, so following the hint stops the run with "Unexpected Fantom environment variable". This makes the message name the variable Fantom actually reads.
Fixes #60063
## Changelog:
[INTERNAL] [FIXED] - Name the right env var in Fantom's heap snapshot error
## Test Plan:
Ran the Fantom Jest config with `FANTOM_ENABLE_MEMORY_INSTRUMENTATION=1`: global setup throws "Unexpected Fantom environment variable". With `FANTOM_ENABLE_JS_MEMORY_INSTRUMENTATION=1` it gets past validation and stops on the expected "Memory instrumentation is not supported in CI or OSS environments" check, so the new hint points at the accepted variable. Message-only change.
Differential Revision: D132533350
Pull Request resolved: #600651 parent 600b2b3 commit 4ceced9
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
791 | 791 | | |
792 | 792 | | |
793 | 793 | | |
794 | | - | |
| 794 | + | |
795 | 795 | | |
796 | 796 | | |
797 | 797 | | |
| |||
0 commit comments