Repository navigation
Conversation
This was referenced Nov 16, 2026
huntie
force-pushed
the
pr60041
branch
3 times, most recently
from
November 16, 2026 16:39
c1f6cb6 to
d904ea4
Compare
Collaborator
Author
|
Abandoning: This remains far from a better final approach, and I don't want to get stuck further in here this week 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
Branch protection on
mainrequires abuild_androidcheck. Test Android skips pull requests that only touch iOS, which leaves that required check pending, so a repo admin needs to drop the requirement before this lands.Test All decides what to run in a
check_code_changesjob built ondorny/paths-filter, and gates every other job on its outputs. Replace it with one workflow per area, Test JS, Test CXX, Test Android, Test iOS and Test Debugger Shell, each skipped by GitHub's own path filters.Impact
Performance: More single-platform pull requests skip the other platform. Over last month's
main, 40 of 474 commits move from both platforms to one. A skipped Android run saves about 110 Linux runner minutes, mostly on billed runners, and a skipped iOS run about 350 macOS minutes. The C++ and Fantom jobs also stop waiting for lint, so their results arrive about 1.6 minutes sooner.An iOS-only pull request that the previous lists missed, such as a SwiftPM tooling change, estimated from the medians of 27 green Test All runs (Nov 13 to 16, 2026):
Simplicity:
dorny/paths-filterexpresses "skip Android when every change is iOS-only" as'**'minus a list of!exclusions underpredicate-quantifier: every, then ORs each output with the event name. Each workflow now carries onepaths-ignorelist, and GitHub skips the workflow when every changed file matches it. Test All's name also no longer described what it ran.Changes
mainand*-stable, and dispatch, withpaths-ignorefor docs and the other platform's sources, build files, tooling and CI.test-js.yml(lint, JS tests, types) andtest-cxx.yml(ReactCommon C++ tests, Fantom), each skipping docs-only pull requests, and removecheck_code_changesanddorny/paths-filter.build_debugger_shelltotest-debugger-shell.yml, triggered bypaths.run_fantom_teststotest_fantomandtest_react_common_cxxtotest_cxx, matchingtest_js.upload-test-resultsand Visual Compare at the new workflows, and add a Jest check that everyworkflow_runtrigger names an existing workflow without glob characters. GitHub matches those names as glob patterns, and a renamed workflow stops triggering its listeners without an error.Changelog: [Internal]
Test Plan
Replayed the 474 commits on
mainfrom Oct 16 to Nov 16, 2026 through the previousdorny/paths-filterlists and the newpaths-ignorelists, usingpicomatchto approximate GitHub's matching.✅ Read every commit that moved: each touches only files for the platform it keeps.
✅ Compared every job in the previous
test-all.yml,test-android.ymlandtest-ios.ymlwith the new files, parsed as YAML. Each job appears once; the differences are the removedcheck_code_changesgate and its callers, a repository check on each workflow's first jobs, and the C++ jobs no longer waiting for lint.✅ Every
workflow_runtrigger names an existing workflow. With the C++ workflow namedTest C++, the check fails, since+is a glob character.ℹ️ Not run in CI yet. On this pull request, check that draft pull requests that are docs-only, Android-only, iOS-only and JS-only start the expected workflows, that Visual Compare and
upload-test-resultsrun after them, and thatyarn test-release-localfinds its artifacts on a*-stablebranch.