Skip to content

[ci] Split Test All into per-area workflows filtered by paths-ignore - #60041

Closed
huntie wants to merge 1 commit into
pr60040from
pr60041
Closed

huntie wants to merge 1 commit into
pr60040from
pr60041

Conversation

@huntie

@huntie huntie commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Note

Branch protection on main requires a build_android check. Test Android skips pull requests that only touch iOS, which leaves that required check pending, so a repo admin needs to drop the requirement before this lands.

Test All decides what to run in a check_code_changes job built on dorny/paths-filter, and gates every other job on its outputs. Replace it with one workflow per area, Test JS, Test CXX, Test Android, Test iOS and Test Debugger Shell, each skipped by GitHub's own path filters.

Impact

Performance: More single-platform pull requests skip the other platform. Over last month's main, 40 of 474 commits move from both platforms to one. A skipped Android run saves about 110 Linux runner minutes, mostly on billed runners, and a skipped iOS run about 350 macOS minutes. The C++ and Fantom jobs also stop waiting for lint, so their results arrive about 1.6 minutes sooner.

An iOS-only pull request that the previous lists missed, such as a SwiftPM tooling change, estimated from the medians of 27 green Test All runs (Nov 13 to 16, 2026):

Before After

Simplicity: dorny/paths-filter expresses "skip Android when every change is iOS-only" as '**' minus a list of ! exclusions under predicate-quantifier: every, then ORs each output with the event name. Each workflow now carries one paths-ignore list, and GitHub skips the workflow when every changed file matches it. Test All's name also no longer described what it ran.

Before After

Changes

  • Run Test Android and Test iOS as top-level workflows on pull requests, pushes to main and *-stable, and dispatch, with paths-ignore for docs and the other platform's sources, build files, tooling and CI.
  • Split the rest of Test All into test-js.yml (lint, JS tests, types) and test-cxx.yml (ReactCommon C++ tests, Fantom), each skipping docs-only pull requests, and remove check_code_changes and dorny/paths-filter.
  • Move build_debugger_shell to test-debugger-shell.yml, triggered by paths.
  • Rename run_fantom_tests to test_fantom and test_react_common_cxx to test_cxx, matching test_js.
  • Point upload-test-results and Visual Compare at the new workflows, and add a Jest check that every workflow_run trigger names an existing workflow without glob characters. GitHub matches those names as glob patterns, and a renamed workflow stops triggering its listeners without an error.
  • Find release-testing artifacts in the Test Android run and the Test iOS run for the same commit.

Changelog: [Internal]

Test Plan

Replayed the 474 commits on main from Oct 16 to Nov 16, 2026 through the previous dorny/paths-filter lists and the new paths-ignore lists, using picomatch to approximate GitHub's matching.

Platforms run Before After
Android and iOS 339 299
iOS only 42 71
Android only 85 96
Neither, docs only 8 8

✅ Read every commit that moved: each touches only files for the platform it keeps.

✅ Compared every job in the previous test-all.yml, test-android.yml and test-ios.yml with the new files, parsed as YAML. Each job appears once; the differences are the removed check_code_changes gate and its callers, a repository check on each workflow's first jobs, and the C++ jobs no longer waiting for lint.

yarn jest .github/workflow-scripts/__tests__/workflow-run-triggers-test.js

✅ Every workflow_run trigger names an existing workflow. With the C++ workflow named Test C++, the check fails, since + is a glob character.

ℹ️ Not run in CI yet. On this pull request, check that draft pull requests that are docs-only, Android-only, iOS-only and JS-only start the expected workflows, that Visual Compare and upload-test-results run after them, and that yarn test-release-local finds its artifacts on a *-stable branch.

@huntie
huntie added this pull request to stack #60042 November 16, 2026 15:32
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2026
@huntie huntie changed the title [ci] Run Android and iOS tests as their own workflows [ci] Split Test All into per-area workflows filtered by paths-ignore Nov 16, 2026
@huntie
huntie removed this pull request from stack #60042 November 16, 2026 16:03
@huntie
huntie added this pull request to stack #60046 November 16, 2026 16:03
@huntie
huntie force-pushed the pr60041 branch 3 times, most recently from c1f6cb6 to d904ea4 Compare November 16, 2026 16:39
@huntie

huntie commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator Author

Abandoning: This remains far from a better final approach, and I don't want to get stuck further in here this week 😅

@huntie huntie closed this Nov 16, 2026
@huntie
huntie removed this pull request from stack #60046 November 16, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant