Skip to content

[ci] Combine visual regression reports across per-platform runs - #60040

Closed
huntie wants to merge 1 commit into
pr60039from
pr60040
Closed

huntie wants to merge 1 commit into
pr60039from
pr60040

Conversation

@huntie

@huntie huntie commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Visual Compare reads one run's captures and builds the approval fingerprint, gate and PR comment from that run alone. Once Android and iOS run as separate workflows, each run holds one platform, so the two reports overwrite each other and an approval of one platform's differences is reset by the other's run. Build the gate and comment from the newest comparison of each platform for the PR head instead.

Impact

  • One approval gate and one comment per PR head, whichever runs captured the platforms.
  • Behavior is unchanged while Test All captures both platforms in one run.

Changes

  • Compare only the platforms the triggering workflow captures: Test Android captures Android, Test iOS captures iOS, and any other workflow captures both.
  • Merge the uploaded results.json of every run for the PR head, newest first per platform, for the fingerprint, gate and comment. Visual Approve uses the same merge.
  • Link another run's platform in the comment through its check run.
  • Serialize Visual Compare per PR head, so the second report sees the first one's results.

Changelog: [Internal]

Test Plan

yarn jest .github/workflow-scripts/__tests__/visual-

✅ New tests cover the workflow-to-platform mapping and the newest-per-platform merge across runs.

ℹ️ Not run in CI yet. The full flow needs the visual bucket, so it shows on the first PR after the platform workflows land.

@huntie

huntie commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator Author

Abandoning: This remains far from a better final approach, and I don't want to get stuck further in here this week 😅

@huntie huntie closed this Nov 16, 2026
@huntie
huntie removed this pull request from stack #60046 November 16, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant