Repository navigation
Conversation
This was referenced Nov 16, 2026
Collaborator
Author
|
Abandoning: This remains far from a better final approach, and I don't want to get stuck further in here this week 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual Compare reads one run's captures and builds the approval fingerprint, gate and PR comment from that run alone. Once Android and iOS run as separate workflows, each run holds one platform, so the two reports overwrite each other and an approval of one platform's differences is reset by the other's run. Build the gate and comment from the newest comparison of each platform for the PR head instead.
Impact
Changes
Test Androidcaptures Android,Test iOScaptures iOS, and any other workflow captures both.results.jsonof every run for the PR head, newest first per platform, for the fingerprint, gate and comment. Visual Approve uses the same merge.Changelog: [Internal]
Test Plan
✅ New tests cover the workflow-to-platform mapping and the newest-per-platform merge across runs.
ℹ️ Not run in CI yet. The full flow needs the visual bucket, so it shows on the first PR after the platform workflows land.