Repository navigation
ci: fix change detection rebuilding everything on main in some cases - #540
Merged
Merged
Conversation
Two bugs compounded so that every push to main built all targets: resolve-base-commit.py found its anchor by listing the branch's successful runs (?branch=main&status=success). That listing has been returning the 2026-08-21 run as the newest even though later runs succeeded, so every diff reached back to that commit. Walk back from HEAD instead and query each commit's runs by head_sha, filtering on branch and conclusion locally. That wide diff contained renames, which `git diff --name-status` reports as "R094 old<TAB>new". BTD rejects the line, and a failed BTD falls back to building everything. Pass --no-renames so they become a D and an A.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve-base-commit.py anchor's by listing the branch's successful runs (?branch=main&status=success). That listing has been returning the 2026-08-21 run as the newest even though later runs succeeded, so every diff reached back to that commit. Walk back from HEAD instead and query each commit's runs by head_sha, filtering on branch and conclusion locally.
A second bug also around renames:
git diff --name-statusreports as "R094 oldnew". BTD rejects the line, and a failed BTD falls back to building everything. Pass --no-renames so they become a D and an A.Since this touches ci everything builds again after this.