Repository navigation
diagnostic_channel: use DisposableStack - #67533
LiviaMedeiros wants to merge 3 commits into
Conversation
Totes three classes: - `DisposableStack` - `AsyncDisposableStack` - `SuppressedError` Signed-off-by: LiviaMedeiros <livia@cirno.name>
This reverts commit b125121.
73881ba to
e3c4ddd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67533 +/- ##
==========================================
- Coverage 90.68% 90.67% -0.02%
==========================================
Files 800 800
Lines 280489 281061 +572
Branches 54173 54308 +135
==========================================
+ Hits 254373 254857 +484
- Misses 16239 16302 +63
- Partials 9877 9902 +25
🚀 New features to boost your workflow:
|
Renegade334
left a comment
There was a problem hiding this comment.
LGTM
The concern about using in core previously was that any PR that uses it won't be backportable to prior release lines. Obviously this specific PR won't be backported anyway, but any change that subsequently touches these methods would then need manual backporting.
That being said, "straightforward" registration of a single non-throwing disposer can just as easily remain try...finally rather than using, so it's only cases like this that require the more complex DisposableStack behaviour that will really need to lean on "true" ERM. I can't imagine there will much need for it elsewhere in core, so the maintenance burden is probably not awful.
e3c4ddd to
b4ab817
Compare
Signed-off-by: LiviaMedeiros <livia@cirno.name>
b4ab817 to
63cd7e3
Compare
aduh95
left a comment
There was a problem hiding this comment.
Now that Node.js 24 is in Maintenance mode, using using in core should be fine – we want to backport that to Node.js 26 though
ERM is unflagged in
v27.x+.This PR
DisposableStack,AsyncDisposableStack,SuppressedErrorprimordialsDisposableStackprimordial instead of global