Skip to content

lib: legitimize SuppressedError as primordial - #67551

Open
LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:lib-suppressederror-primordial
Open

LiviaMedeiros wants to merge 1 commit into
nodejs:mainfrom
LiviaMedeiros:lib-suppressederror-primordial

Conversation

@LiviaMedeiros

Copy link
Copy Markdown
Member

Blocked on: #67533 which would add it to primordials first, together with DisposableStack and AsyncDisposableStack.

Signed-off-by: LiviaMedeiros <livia@cirno.name>
@LiviaMedeiros LiviaMedeiros added blocked PRs that are blocked by other issues or PRs. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Nov 17, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. stream Issues and PRs related to Node.js streams. labels Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (1727b13) to head (bd8c1f2).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #67551   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files         800      800           
  Lines      281001   281000    -1     
  Branches    54286    54288    +2     
=======================================
+ Hits       254797   254808   +11     
- Misses      16295    16304    +9     
+ Partials     9909     9888   -21     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/streams/iter/consumers.js 97.47% <100.00%> (+0.14%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. stream Issues and PRs related to Node.js streams.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants