Skip to content

fix(config): add missing spaces in riscv64 threads warning #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 1 commit into from
Jul 28, 2026
+8 −2
Merged

fix(config): add missing spaces in riscv64 threads warning #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/riscv64-warning-spacing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@node-core/doc-kit': patch
---

Fix missing spaces in the riscv64 multithreading warning message, which
previously concatenated as "failures whenallocating" and "spaceon riscv64".
4 changes: 2 additions & 2 deletions src/utils/configuration/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ export const createRunConfiguration = async options => {

if (process.arch === 'riscv64' && merged.threads > 1) {
logger.warn(
`Using ${merged.threads} threads might cause failures when` +
'allocating wasm memory due to insufficient virtual address space' +
`Using ${merged.threads} threads might cause failures when ` +
'allocating wasm memory due to insufficient virtual address space ' +
'on riscv64 with sv39. Please consider using only a single thread.'
);
}
Expand Down
Loading