Skip to content

fix(config): add missing spaces in riscv64 threads warning - #946

Merged
avivkeller merged 1 commit into
nodejs:mainfrom
btea:fix/riscv64-warning-spacing
Jul 28, 2026
Merged

fix(config): add missing spaces in riscv64 threads warning#946
avivkeller merged 1 commit into
nodejs:mainfrom
btea:fix/riscv64-warning-spacing

Conversation

@btea

@btea btea commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

The warning shown when running with multiple threads on riscv64 concatenated its string parts without trailing spaces, producing failures whenallocating and address spaceon riscv64.

This adds the missing spaces so the message reads correctly.

@btea
btea requested a review from a team as a code owner July 27, 2026 13:11
Copilot AI review requested due to automatic review settings July 27, 2026 13:11
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Jul 27, 2026 1:12pm

Request Review

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

@btea is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cursor

cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
User-visible warning text only; no behavior or configuration logic changes.

Overview
Fixes word concatenation in the riscv64 multithreading warning emitted from createRunConfiguration when merged.threads > 1 on riscv64.

Trailing spaces are added between the concatenated string fragments so the message reads “failures when allocating” and “virtual address space on riscv64” instead of whenallocating and spaceon.

A patch changeset documents the fix for @node-core/doc-kit.

Reviewed by Cursor Bugbot for commit 8777f37. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.21%. Comparing base (cef45ca) to head (8777f37).

Files with missing lines Patch % Lines
src/utils/configuration/index.mjs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files         195      195           
  Lines       17690    17690           
  Branches     1609     1610    +1     
=======================================
  Hits        15251    15251           
  Misses       2433     2433           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller
avivkeller merged commit 9ab2840 into nodejs:main Jul 28, 2026
24 of 25 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 28, 2026
@btea
btea deleted the fix/riscv64-warning-spacing branch July 28, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants