Skip to content

Add billing phone verification inputs - #294

Draft
oschwald wants to merge 2 commits into
mainfrom
greg/billing-phone-verification-inputs
Draft

oschwald wants to merge 2 commits into
mainfrom
greg/billing-phone-verification-inputs

Conversation

@oschwald

@oschwald oschwald commented Oct 9, 2026

Copy link
Copy Markdown
Member

Adds three optional inputs to withBilling(), as array keys or named arguments: phone_verification_method (delivered_code, network, other), phone_was_verification_successful (boolean), and phone_verification_time (RFC 3339 date-time). They describe the most recent verification of the billing phone number. When input validation is on, the client checks the method value, the boolean type and the time format. The first commit moves the RFC 3339 check into one helper that the event time also uses.
Reviewer question: the new named arguments are in alphabetical order, between $phoneNumber and $postal, as the tracking_token change did. A caller who passes $postal or $region by position would shift into the new arguments. Should they go at the end instead?

🤖 Generated with Claude Code

oschwald and others added 2 commits October 9, 2026 20:47
Move the event time check from withEvent into a private helper so other
inputs can use the same check. Behavior does not change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add phone_verification_method, phone_was_verification_successful, and
phone_verification_time to withBilling(), as array keys or named
arguments. These describe the most recent verification of the billing
phone number. With input validation enabled, the method must be
delivered_code, network, or other, the success flag must be a boolean,
and the time must be an RFC 3339 date-time. Shipping does not get these
inputs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant