Repository navigation
Conversation
Move the event time check from withEvent into a private helper so other inputs can use the same check. Behavior does not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add phone_verification_method, phone_was_verification_successful, and phone_verification_time to withBilling(), as array keys or named arguments. These describe the most recent verification of the billing phone number. With input validation enabled, the method must be delivered_code, network, or other, the success flag must be a boolean, and the time must be an RFC 3339 date-time. Shipping does not get these inputs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three optional inputs to
withBilling(), as array keys or named arguments:phone_verification_method(delivered_code,network,other),phone_was_verification_successful(boolean), andphone_verification_time(RFC 3339 date-time). They describe the most recent verification of the billing phone number. When input validation is on, the client checks the method value, the boolean type and the time format. The first commit moves the RFC 3339 check into one helper that the event time also uses.Reviewer question: the new named arguments are in alphabetical order, between
$phoneNumberand$postal, as thetracking_tokenchange did. A caller who passes$postalor$regionby position would shift into the new arguments. Should they go at the end instead?🤖 Generated with Claude Code