Skip to content

[steps][4/4] Resolve composite function outputs - #4015

Merged
sswrk merged 2 commits into
mainfrom
szymonswierk/eng-22387-steps-resolve-action-outputs
Jul 24, 2026
Merged

[steps][4/4] Resolve composite function outputs#4015
sswrk merged 2 commits into
mainfrom
szymonswierk/eng-22387-steps-resolve-action-outputs

Conversation

@sswrk

@sswrk sswrk commented Jul 14, 2026

Copy link
Copy Markdown
Member

Why

This PR stack adds local composite functions for EAS workflows. A function.yml declares outputs: with templated values, and the caller should read them as ${{ steps.setup.outputs.version }}, where setup is the id of the calling step.

After the previous PRs, data flows into a composite function (inputs, env) but nothing flows back out. This PR closes that loop.

How

For a composite function that declares outputs:, CompositeFunctionExpander appends a synthetic function step after the inner steps, reusing the caller's step id.

  • The step runs with if: ${{ always() }}
  • Output values are interpolated against the composite-function-local step namespace

Test Plan

Added outputs unit tests.

@linear-code

linear-code Bot commented Jul 14, 2026

Copy link
Copy Markdown

ENG-22387

sswrk commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

@sswrk sswrk changed the title [steps] Resolve action outputs [steps][5/5] Resolve action outputs Jul 14, 2026
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.48%. Comparing base (a8e8c79) to head (562532f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4015      +/-   ##
==========================================
+ Coverage   61.29%   61.48%   +0.19%     
==========================================
  Files         977      978       +1     
  Lines       43687    43839     +152     
  Branches     9186     9217      +31     
==========================================
+ Hits        26774    26948     +174     
+ Misses      15465    15443      -22     
  Partials     1448     1448              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 012162e to e861a4f Compare July 14, 2026 13:02
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch 2 times, most recently from 68b6cdf to e31b8bc Compare July 14, 2026 13:25
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch 2 times, most recently from 4fc12bc to f2f853b Compare July 14, 2026 13:35
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from e31b8bc to 7937bd7 Compare July 14, 2026 13:35
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from f2f853b to 49218d5 Compare July 14, 2026 13:44
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from 7937bd7 to 709a789 Compare July 14, 2026 13:45
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 49218d5 to 4fc0d2d Compare July 14, 2026 14:12
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from 709a789 to 1b037d3 Compare July 14, 2026 14:12
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 4fc0d2d to 6a46ebb Compare July 14, 2026 14:28
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from 1b037d3 to 051d1fa Compare July 14, 2026 14:28
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 6a46ebb to 6487bd5 Compare July 14, 2026 14:57
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch 2 times, most recently from 515cccd to 901e44a Compare July 14, 2026 16:04
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch 2 times, most recently from ea64846 to 31f7032 Compare July 14, 2026 17:37
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from 901e44a to 1e42623 Compare July 14, 2026 17:37
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 31f7032 to b1da672 Compare July 14, 2026 17:57
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from 8c24784 to 6613344 Compare July 17, 2026 14:23
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 31603cd to 0e4346f Compare July 17, 2026 14:23
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from 6613344 to c92328e Compare July 17, 2026 14:33
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 0e4346f to 894b6a9 Compare July 17, 2026 14:33
@sswrk
sswrk marked this pull request as ready for review July 17, 2026 16:17

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 894b6a9 to cac70ba Compare July 21, 2026 14:19
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from c92328e to 9ba7a45 Compare July 21, 2026 14:19
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch 2 times, most recently from 421648f to f3a7fc8 Compare July 22, 2026 14:16
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch 2 times, most recently from 7e50713 to c88f637 Compare July 23, 2026 14:40
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from f3a7fc8 to 7377a54 Compare July 23, 2026 14:40
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-resolve-action-outputs branch from 7377a54 to b2b2a7f Compare July 23, 2026 17:06
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from c88f637 to cf59282 Compare July 23, 2026 17:06
@sswrk
sswrk requested review from hSATAC and sjchmiela July 23, 2026 17:17
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-interpolate-action-inputs branch from cf59282 to 568d438 Compare July 24, 2026 11:43
sswrk added 2 commits July 24, 2026 15:15
The outputs node is owned by CompositeBuildStep after the resolve-outputs restack; update test titles to match.
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants