Skip to content

[steps][1/4] Add isCompositeFunctionPath and reject local composite functions in custom builds - #3956

Merged
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-22387-steps-local-action-discovery
Jul 24, 2026
Merged

[steps][1/4] Add isCompositeFunctionPath and reject local composite functions in custom builds#3956
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-22387-steps-local-action-discovery

Conversation

@sswrk

@sswrk sswrk commented Jul 6, 2026

Copy link
Copy Markdown
Member

Why

Local composite functions use uses: ./... paths. Custom build configs (.eas/build/*.yml) must reject these early with a clear error.

How

  • Adds isCompositeFunctionPath in localCompositeFunctions.ts
  • Rejects local composite function paths in validateAllFunctionsExist for custom builds

Test Plan

Added unit tests.

@linear-code

linear-code Bot commented Jul 6, 2026

Copy link
Copy Markdown

ENG-22387

sswrk commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@sswrk sswrk added the no changelog PR that doesn't require a changelog entry label Jul 6, 2026
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.13%. Comparing base (197edf5) to head (1badf0f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3956      +/-   ##
==========================================
+ Coverage   61.13%   61.13%   +0.01%     
==========================================
  Files         971      972       +1     
  Lines       43431    43439       +8     
  Branches     9135     9137       +2     
==========================================
+ Hits        26546    26554       +8     
  Misses      15439    15439              
  Partials     1446     1446              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch 3 times, most recently from ea3cab3 to c230ee8 Compare July 6, 2026 15:20
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from c230ee8 to 745c9a3 Compare July 13, 2026 18:08
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 06676aa to 581492e Compare July 13, 2026 18:08
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from 745c9a3 to 69fbddb Compare July 13, 2026 19:55
@sswrk sswrk changed the title [steps] Add local action discovery utilities [steps][1/3] Add local action discovery utilities Jul 13, 2026
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from 69fbddb to 31fd159 Compare July 14, 2026 08:56
@sswrk sswrk changed the title [steps][1/3] Add local action discovery utilities [steps][1/5] Add local action discovery utilities Jul 14, 2026
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch 4 times, most recently from ce7b043 to 098fd12 Compare July 14, 2026 16:04
@sswrk
sswrk marked this pull request as ready for review July 14, 2026 16:10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@sswrk
sswrk requested a review from sjchmiela July 14, 2026 16:11

@sjchmiela sjchmiela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preliminary review -- i would also maybe recommend moving the here-unused functions to the pull request which starts using them cause it's harder to understand the context like this

Comment thread packages/steps/src/utils/localActions.ts Outdated
Comment thread packages/steps/src/utils/localActions.ts Outdated
Comment thread packages/steps/src/utils/localActions.ts Outdated
Comment thread packages/steps/src/utils/localActions.ts Outdated
Comment thread packages/steps/src/utils/localActions.ts Outdated
Comment thread packages/steps/src/utils/localActions.ts Outdated
Comment thread packages/steps/src/utils/localActions.ts Outdated
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 581492e to 98feeaf Compare July 15, 2026 12:06
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from b9e22f0 to 1f09bb9 Compare July 17, 2026 13:43
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from bb846e8 to e5d1065 Compare July 21, 2026 14:19
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from 6b15afe to e9427a7 Compare July 22, 2026 14:16
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch 2 times, most recently from 8037f2f to ddec1d1 Compare July 23, 2026 14:40
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from e9427a7 to ec3a2b1 Compare July 23, 2026 14:40
@sswrk sswrk changed the title [steps][1/4] Add isCompositeFunctionPath and reject local composite functions in custom builds [steps][1/4] Add isCompositeFunctionPath and reject local composite functions in custom builds Jul 23, 2026
@brentvatne brentvatne added the ai-review Commits pushed to PRs with this label be automatically reviewed. label Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Approve with comments

⚠️ The AI review could not complete: every review pass failed or timed out, so these changes were effectively NOT reviewed. Treat this as "no review", not "looks good".

⏱️ Coverage note: coverage is partial — some review passes did not
finish (timed out or failed), so issues may exist in areas not fully reviewed:

  • The consistency review failed to run; those changes were not reviewed.
  • The correctness review failed to run; those changes were not reviewed.
  • The security review failed to run; those changes were not reviewed.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from ddec1d1 to 3d859f0 Compare July 23, 2026 17:06
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-eas-build-job-local-action-schema branch from ec3a2b1 to b4397b8 Compare July 24, 2026 11:43
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from 3d859f0 to 355f7a8 Compare July 24, 2026 11:43
@sswrk
sswrk changed the base branch from szymonswierk/eng-22387-eas-build-job-local-action-schema to graphite-base/3956 July 24, 2026 12:28
@sswrk
sswrk force-pushed the graphite-base/3956 branch from b4397b8 to 197edf5 Compare July 24, 2026 12:28
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from 355f7a8 to 6b3fb2e Compare July 24, 2026 12:28
@graphite-app
graphite-app Bot changed the base branch from graphite-base/3956 to main July 24, 2026 12:29
@sswrk
sswrk force-pushed the szymonswierk/eng-22387-steps-local-action-discovery branch from 6b3fb2e to 1badf0f Compare July 24, 2026 12:29
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed. no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants