[steps][1/4] Add isCompositeFunctionPath and reject local composite functions in custom builds - #3956
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3956 +/- ##
==========================================
+ Coverage 61.13% 61.13% +0.01%
==========================================
Files 971 972 +1
Lines 43431 43439 +8
Branches 9135 9137 +2
==========================================
+ Hits 26546 26554 +8
Misses 15439 15439
Partials 1446 1446 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ea3cab3 to
c230ee8
Compare
c230ee8 to
745c9a3
Compare
06676aa to
581492e
Compare
745c9a3 to
69fbddb
Compare
69fbddb to
31fd159
Compare
ce7b043 to
098fd12
Compare
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
sjchmiela
left a comment
There was a problem hiding this comment.
preliminary review -- i would also maybe recommend moving the here-unused functions to the pull request which starts using them cause it's harder to understand the context like this
581492e to
98feeaf
Compare
b9e22f0 to
1f09bb9
Compare
bb846e8 to
e5d1065
Compare
6b15afe to
e9427a7
Compare
8037f2f to
ddec1d1
Compare
e9427a7 to
ec3a2b1
Compare
isCompositeFunctionPath and reject local composite functions in custom builds
🤖 AI code reviewDecision: Approve with comments
No findings. This review is advisory — it never blocks a merge and never auto-approves. |
ddec1d1 to
3d859f0
Compare
ec3a2b1 to
b4397b8
Compare
3d859f0 to
355f7a8
Compare
b4397b8 to
197edf5
Compare
355f7a8 to
6b3fb2e
Compare
…unctions in custom builds
6b3fb2e to
1badf0f
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |

Why
Local composite functions use
uses: ./...paths. Custom build configs (.eas/build/*.yml) must reject these early with a clear error.How
isCompositeFunctionPathinlocalCompositeFunctions.tsvalidateAllFunctionsExistfor custom buildsTest Plan
Added unit tests.