feat(reader): read vortex.parquet.variant (#445) - #456
Merged
Merged
Conversation
vortex-jni's default writer turns an Arrow arrow.parquet.variant column
into vortex.variant over vortex.parquet.variant (core2026.08.3, Rust's
default edition), which vortex-java could not decode.
ParquetVariantEncodingDecoder follows Rust's ParquetVariant::deserialize:
proto metadata {has_value, typed_value_dtype, value_nullable}, no
buffers, children [validity?, metadata, value?, typed_value?]. It decodes
to a StructArray {metadata, value?, typed_value?}, Arrow's own storage
shape for the extension, masked by row validity; no new Array type.
Rust dict-encodes the Binary value child, which exposed that
DictEncodingDecoder only routed Utf8 through its VarBin path: a Binary
dictionary hit a (DType.Primitive) cast and leaked ClassCastException.
Binary now shares the Utf8 path, and any other non-primitive dtype
throws VortexException.
Writing vortex.parquet.variant stays out of scope (ADR 0014).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vortex-jni's default writer turns an Arrow arrow.parquet.variant column
into vortex.variant over vortex.parquet.variant (core2026.08.3, Rust's
default edition), which vortex-java could not decode.
ParquetVariantEncodingDecoder follows Rust's ParquetVariant::deserialize:
proto metadata {has_value, typed_value_dtype, value_nullable}, no
buffers, children [validity?, metadata, value?, typed_value?]. It decodes
to a StructArray {metadata, value?, typed_value?}, Arrow's own storage
shape for the extension, masked by row validity; no new Array type.
Rust dict-encodes the Binary value child, which exposed that
DictEncodingDecoder only routed Utf8 through its VarBin path: a Binary
dictionary hit a (DType.Primitive) cast and leaked ClassCastException.
Binary now shares the Utf8 path, and any other non-primitive dtype
throws VortexException.
Writing vortex.parquet.variant stays out of scope (ADR 0014).
Closes #445.
Verified with
./mvnw verify(unit + integration), including the newParquetVariantInteropIntegrationTest(vortex-jni-written plain and shredded columns).🤖 Generated with Claude Code