feat(reader): read vortex.zstd_buffers (#444) - #457
Merged
Merged
Conversation
dfa1
force-pushed
the
feat/zstd-buffers-read
branch
from
October 4, 2026 06:41
dd6e125 to
056f14a
Compare
vortex.zstd_buffers (Rust's opt-in zstd2026.02.0 edition) wraps any array and Zstd-compresses each of its buffers independently, keeping the layout. ZstdBuffersEncodingDecoder follows Rust's deserialize/build_inner: decompress every buffer at its declared alignment, append the segments to the context, and decode the inner encoding (id + metadata from the proto) over them with its own children. Self-nested zstd_buffers levels, which nest through metadata the file depth guard never sees, unwrap in a loop rather than recursing. vortex-jni cannot emit the encoding, so a checked-in fixture written by Rust's own ZstdBuffers::compress (scripts/fixtures/zstd-buffers) stands in. Reading it exposed two pre-existing bugs: - VarBinEncodingDecoder ignored the validity child: null rows of a Rust-written nullable vortex.varbin read back as empty values. - A corrupt vortex.zstd frame leaked the binding's ZstdException; frame decompression is now one shared helper that wraps it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
feat/zstd-buffers-read
branch
from
October 4, 2026 06:41
056f14a to
80cb739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vortex.zstd_buffers (Rust's opt-in zstd2026.02.0 edition) wraps any
array and Zstd-compresses each of its buffers independently, keeping the
layout. ZstdBuffersEncodingDecoder follows Rust's deserialize/build_inner:
decompress every buffer at its declared alignment, append the segments
to the context, and decode the inner encoding (id + metadata from the
proto) over them with its own children. Self-nested zstd_buffers levels,
which nest through metadata the file depth guard never sees, unwrap in a
loop rather than recursing.
vortex-jni cannot emit the encoding, so a checked-in fixture written by
Rust's own ZstdBuffers::compress (scripts/fixtures/zstd-buffers) stands
in. Reading it exposed two pre-existing bugs:
Rust-written nullable vortex.varbin read back as empty values.
decompression is now one shared helper that wraps it.
Closes #444. Stacked on #456 — merge that first, then retarget this to
main.Verified with
./mvnw verify(unit + integration).🤖 Generated with Claude Code