Repository navigation
Conversation
… pool tracking and zero-length UnsafeAppend Closes apache#55685
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DeltaLengthByteArrayEncodercurrently overwrites the caller'sMemoryPool*withdefault_memory_pool()in its constructor initializer list (affecting bothDELTA_LENGTH_BYTE_ARRAYandDELTA_BYTE_ARRAY'ssuffix_encoder_), and callsBufferBuilder::UnsafeAppendon zero-lengthByteArrayitems (which triggers UB under UBSan whenptr == nullptr).Split out from #55488 so these fixes can be reviewed separately from the
PutBinaryArrayoptimization.What changes are included in this PR?
pooldirectly inDeltaLengthByteArrayEncoder's constructor instead of reassigning it todefault_memory_pool().sink_.Reserve/sink_.UnsafeAppendfor zero-length items inDeltaLengthByteArrayEncoder::Put(const ByteArray*, int).Are these changes tested?
Yes, added unit tests in
cpp/src/parquet/encoding_test.ccfor custom memory pool tracking (for bothDELTA_LENGTH_BYTE_ARRAYandDELTA_BYTE_ARRAY) and zero-lengthByteArray(0, nullptr)inputs.Are there any user-facing changes?
Callers passing a custom
MemoryPool*when encodingDELTA_LENGTH_BYTE_ARRAYorDELTA_BYTE_ARRAYcolumns will now have encoder allocations tracked on that pool.Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
Closes #55685