Repository navigation
Conversation
|
|
|
|
Member
|
@ryanvickr Can you please rewrite the PR description to be more terse and higher-level than the current AI-generated details? Thanks in advance. |
Member
|
@ryanvickr I think it would be worth doing a separate PR for the two simple fixes (pass memory pool and avoid calling UnsafeAppend on zero-length strings). Can you do that so that the performance optimization can be discussed independently? |
…yloads in DeltaLengthByteArrayEncoder::PutBinaryArray Closes apache#55487
ryanvickr
force-pushed
the
gh-55487-fix-dlba-encoder
branch
from
November 20, 2026 03:59
9d41a76 to
cc04079
Compare
3 of 5 tasks
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DeltaLengthByteArrayEncoder::PutBinaryArraycurrently encodes Arrow binary/string lengths one value at a time and appends payloads without pre-reservingsink_, whereasPut(const ByteArray*, int)batches lengths and pre-reserves capacity.The memory pool and zero-length
UnsafeAppendfixes previously in this PR have been split out into #55686.What changes are included in this PR?
sink_capacity inDeltaLengthByteArrayEncoder::PutBinaryArray.Are these changes tested?
Yes, added unit tests in
cpp/src/parquet/encoding_test.cccovering batch boundaries, slices,StringViewArray, multi-Putaccumulation, and invalid/overflowing offset rejection.Are there any user-facing changes?
No.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
Closes #55487