Skip to content

GH-50149: [C++][Parquet] Avoid process abort when encoding fuzzer encounters OOM #50150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 1 commit into from
Jun 11, 2026
Merged

GH-50149: [C++][Parquet] Avoid process abort when encoding fuzzer encounters OOM #50150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions cpp/src/parquet/arrow/fuzz_encoding_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,23 +290,24 @@ struct TypedFuzzEncoding {
}

// Re-encode and re-decode using roundtrip encoding
{
auto compare_chunk = [&](int offset, std::span<const c_type> chunk_values) {
return CompareChunkAgainstReference(offset, chunk_values);
};
auto compare_chunk = [&](int offset, std::span<const c_type> chunk_values) {
return CompareChunkAgainstReference(offset, chunk_values);
};
auto do_roundtrip = [&]() -> Status {
auto encoder = MakeEncoder(roundtrip_encoding_);
BEGIN_PARQUET_CATCH_EXCEPTIONS
if constexpr (arrow_supported()) {
encoder->Put(*reference_array_);
auto reencoded_buffer = encoder->FlushValues();
auto reencoded_data = reencoded_buffer->template span_as<uint8_t>();
auto array = DecodeArrow(roundtrip_encoding_, reencoded_data).ValueOrDie();
ARROW_CHECK_OK(array->ValidateFull());
ARROW_CHECK_OK(CompareAgainstReference(array));
ARROW_ASSIGN_OR_RAISE(auto array,
DecodeArrow(roundtrip_encoding_, reencoded_data));
RETURN_NOT_OK(array->ValidateFull());
RETURN_NOT_OK(CompareAgainstReference(array));
// Compare with reading raw values
for (const int chunk_size : chunk_sizes()) {
ARROW_CHECK_OK(RunOnDecodedChunks(roundtrip_encoding_, reencoded_data,
chunk_size, compare_chunk));
RETURN_NOT_OK(RunOnDecodedChunks(roundtrip_encoding_, reencoded_data,
chunk_size, compare_chunk));
}
} else {
encoder->Put(reference_values_.data(),
Expand All @@ -315,14 +316,19 @@ struct TypedFuzzEncoding {
auto reencoded_data = reencoded_buffer->template span_as<uint8_t>();
// Vary chunk sizes
for (const int chunk_size : chunk_sizes()) {
ARROW_CHECK_OK(RunOnDecodedChunks(roundtrip_encoding_, reencoded_data,
chunk_size, compare_chunk));
RETURN_NOT_OK(RunOnDecodedChunks(roundtrip_encoding_, reencoded_data,
chunk_size, compare_chunk));
}
}
END_PARQUET_CATCH_EXCEPTIONS

@adamreeve adamreeve Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that there is another behaviour change. Previously any Parquet exceptions would be converted to a status code return value, but now they will get checked below and treated as a fatal error. That seems appropriate though.

@pitrou pitrou Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, and that's for the better indeed.

return Status::OK();
};
Status roundtrip_status = do_roundtrip();
// OOM when attempting to roundtrip is not a hard failure, any other error is.
if (!roundtrip_status.IsOutOfMemory()) {
ARROW_CHECK_OK(roundtrip_status);
}

return Status::OK();
return roundtrip_status;
}

protected:
Expand Down
2 changes: 1 addition & 1 deletion testing
Open in desktop
Submodule testing updated 1 files
+ − data/parquet/encoding-fuzzing/clusterfuzz-testcase-parquet-encoding-fuzz-6275824868458496
Loading