Skip to content

GH-50149: [C++][Parquet] Avoid process abort when encoding fuzzer encounters OOM#50150

Merged
pitrou merged 1 commit into
apache:mainfrom
pitrou:gh50149-encoding-oom
Jun 11, 2026
Merged

GH-50149: [C++][Parquet] Avoid process abort when encoding fuzzer encounters OOM#50150
pitrou merged 1 commit into
apache:mainfrom
pitrou:gh50149-encoding-oom

Conversation

@pitrou

@pitrou pitrou commented Jun 10, 2026

Copy link
Copy Markdown
Member

Rationale for this change

In the Parquet encoding fuzzer, an OOM error when trying to roundtrip the encoding payload leads to a hard error that is reported as an issue on OSS-Fuzz. This should be converted to a soft error, i.e. a potential log message but not a process abort.

Are these changes tested?

By additional fuzz regression file as well as manually.

Are there any user-facing changes?

No.

@pitrou

pitrou commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit fuzz

@pitrou pitrou requested a review from adamreeve June 10, 2026 14:31
@github-actions

Copy link
Copy Markdown

Revision: 1cbeef7

Submitted crossbow builds: ursacomputing/crossbow @ actions-19765c5446

Task Status
test-build-cpp-fuzz GitHub Actions

@adamreeve adamreeve left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense to me

@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 10, 2026
chunk_size, compare_chunk));
}
}
END_PARQUET_CATCH_EXCEPTIONS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that there is another behaviour change. Previously any Parquet exceptions would be converted to a status code return value, but now they will get checked below and treated as a fatal error. That seems appropriate though.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, and that's for the better indeed.

@pitrou pitrou merged commit ed536d1 into apache:main Jun 11, 2026
53 of 54 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Jun 11, 2026
@pitrou pitrou deleted the gh50149-encoding-oom branch June 11, 2026 08:03
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Jun 11, 2026
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ed536d1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants