Skip to content

Fix incorrect parameters in np.argmax() for Genetic Algorithm in tsp.py #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmeoli merged 4 commits into from
Jun 26, 2026
Merged

Fix incorrect parameters in np.argmax() for Genetic Algorithm in tsp.py #1297

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25f19c3
Fix incorrect parameters in np.argmax() for Genetic Algorithm in tsp.py
mohsinm-dev Jun 11, 2024
fcc85b8
Fix ValueError in test_svc for test_learning.py and test_learning4e.py
mohsinm-dev Jun 11, 2024
57f0cf4
Merge remote-tracking branch 'upstream/master' into pr1297-work
dmeoli Jun 26, 2026
03d4e1a
Use utils.argmax_random_tie for best-individual selection in tsp.py
dmeoli Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gui/tsp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def fitness_fn(state):
while True:
population = [mutate(recombine(*select(2, population, fitness_fn)), self.mutation_rate.get())
for _ in range(len(population))]
current_best = np.argmax(population, key=fitness_fn)
current_best = utils.argmax_random_tie(population, key=fitness_fn)
if fitness_fn(current_best) > fitness_fn(all_time_best):
all_time_best = current_best
self.cost.set("Cost = " + str('%0.3f' % (-1 * problem.value(all_time_best))))
Expand Down Expand Up @@ -294,7 +294,7 @@ def find_neighbors(state, number_of_neighbors=100):
current = Node(problem.initial)
while True:
neighbors = find_neighbors(current.state, self.no_of_neighbors.get())
neighbor = np.argmax_random_tie(neighbors, key=lambda node: problem.value(node.state))
neighbor = utils.argmax_random_tie(neighbors, key=lambda node: problem.value(node.state))
map_canvas.delete('poly')
points = []
for city in current.state:
Expand Down