Fix incorrect parameters in np.argmax() for Genetic Algorithm in tsp.py#1297
Merged
Conversation
Issue aimacode#1256: Replace np.argmax with argmax_random_ties to correctly reference method and avoid TypeError.
Issue aimacode#1272: Updated optimizer parameter from lr to learning_rate in deep_learning4e.py to resolve Rank(A) < p error.
weasdown
added a commit
to weasdown/aima-python
that referenced
this pull request
Feb 5, 2025
np.argmax does not accept a key argument (TypeError), and np.argmax_random_tie does not exist (argmax_random_tie lives in utils). Use utils.argmax_random_tie in both the genetic algorithm and hill climbing loops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1256: Replace np.argmax with argmax_random_ties to correctly reference method and avoid TypeError.