Skip to content

Icons: Use snake_case file_path key in icon registry#12149

Open
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:64847-icons/snake-case
Open

Icons: Use snake_case file_path key in icon registry#12149
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:64847-icons/snake-case

Conversation

@t-hamano

@t-hamano t-hamano commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Use of AI Tools

Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.

@t-hamano t-hamano marked this pull request as ready for review June 11, 2026 02:51
@github-actions

github-actions Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano t-hamano mentioned this pull request Jun 11, 2026
Closed
@t-hamano @claude
Icons: Use snake_case file_path internally in the icon registry.
a51f22e 
Align the icon registry's internal property with WordPress core's
snake_case array-key convention by renaming the registered icon property
from filePath to file_path. The conversion now happens only at the
registration/mapping boundary in the constructor: the generated manifest
keeps the upstream camelCase `filePath` key (as produced by Gutenberg),
which is read and mapped to the internal `file_path` property when each
icon is registered.

This updates the registry validation, allowed property keys,
`get_content()` lookup, and the related docblocks and error messages,
while leaving the manifest and the copy:icon-library-manifest Grunt task
untouched.

Co-Authored-By: Claude <noreply@anthropic.com>
@t-hamano t-hamano force-pushed the 64847-icons/snake-case branch from 07278a7 to a51f22e Compare June 11, 2026 06:43
@t-hamano t-hamano changed the title Icons: Rename icon manifest key filePath to file_path. Icons: Use snake_case file_path key in icon registry Jun 11, 2026
This was referenced Jun 11, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@t-hamano