Icons: Add show_in_rest support to gate REST API exposure.#1
Closed
t-hamano wants to merge 3 commits into
Closed
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
64847-icons/snake-case
branch
from
07278a7 to
a51f22e
Compare
Align the icon registry and generated manifest with WordPress core's snake_case array-key convention, which is the dominant style across core PHP. This updates the manifest entries, the registry validation and `get_content()` lookup, the allowed property keys, and the related docblocks and error messages. Mirrors the same rename made on the Gutenberg side in WordPress/gutenberg#79100. Co-Authored-By: Claude <noreply@anthropic.com>
Following the upstream Gutenberg rename of the icon manifest key from filePath to file_path (WordPress/gutenberg#79100), adjust the copy:icon-library-manifest Grunt task to match the new file_path key when stripping the 'library/' path prefix, so regeneration keeps producing valid icon paths. Co-Authored-By: Claude <noreply@anthropic.com>
Introduce a `show_in_rest` icon property so that REST visibility can be controlled independently from registry membership. The registry accepts and validates the boolean property, while the REST controller filters listings and single-icon requests to icons flagged for REST exposure. This allows all manifest icons to be registered for internal use while exposing only a subset through the public REST API. Co-Authored-By: Claude <noreply@anthropic.com>
t-hamano
force-pushed
the
64847-icons/expose-all-icons
branch
from
c20ed94 to
df1868a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_pathkey in icon registry WordPress/wordpress-develop#12149aligncenterregardless of what is selected in the toolbar WordPress/gutenberg#7910Use of AI Tools
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.