Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an old bug where a demoman's shield floats in midair after respawn. The shield is visible through walls and players.
How to reproduce
Screenshot
Cause
During firstperson spectating,
GetViewModel(0)returns the spectated players viewmodel. The demoman's shield model attaches to it. After the demo respawns, the shield remains at that location and floats in the world.Fix
Use
GetViewModel(0, false)when creating the shield model. This returns the demos own viewmodel, so the shield cannot attach to the player being spectated.