Repository navigation
Keep empty chained vectors valid when resizing to zero - #128
Merged
Merged
Conversation
Return before modifying storage when the requested length is unchanged. Verify empty vectors remain usable after resizing, pushing, and appending. Co-authored by Codex AI disclosure: This work was prepared with assistance from OpenAI Codex.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizing an already empty ChainedVector to zero enters the shrinking branch, grows its chunk and offset storage to one slot, and throws UndefRefError while reading the unassigned chunk. Return early when the requested length equals the current length so a no-op resize keeps the vector valid.
Add 39 regression checks for newly created empty vectors, empty input chunks, empty!, pop!, repeated shrinking to zero, and reuse through push! and append!. Also cover a no-op resize on a nonempty vector and rejection of negative lengths.
Validation: the unchanged base reproduces UndefRefError and leaves one unassigned chunk slot. The complete suite passes on Julia 1.12.6, including all 39 new checks. A separate 14-check usability probe passes on Julia 1.6.7.
Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.