Repository navigation
feat: accept the table view style - #270
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
doistbot
reviewed
Nov 2, 2026
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR cleanly adds table as a fourth project view style, updating the ViewStyle definitions, the add_project/update_project docstrings, and extending the parametrized test coverage for both sync and async clients. No inline issues were flagged. One minor note: the allowed values now live as two parallel ViewStyle definitions that must be kept in sync manually — worth keeping an eye on as view styles evolve, though unifying them may be out of scope here.
I also included a few optional follow-up notes in the details below.
Optional follow-up notes (2)
todoist_api_python/types.py:38: The allowed values are duplicated here and in
models.py'sViewStyleLiteral, so every new view style (like this PR's "table") must be added in both places. To keep a single source of truth,types.pycould reuse the Literal, e.g.Predicate(lambda value: value in get_args(models.ViewStyle)), or the Literal could be defined here and re-exported bymodels.py.tests/test_api_projects.py:163:
test_add_project_fullnow coverstableforadd_project, but the same PR also addstabletoupdate_projectand no test passesview_stylethrough that path (test_update_project'sargsomit it). Addview_style: "table"totest_update_project's request/response args, or parameterize that test as well, so the update passthrough is protected.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
What was changed
add_project/update_projectacceptview_style="table", andViewStyleincludes it.test_add_project_fullcoverstableas well asboard.Refs
🤖 Generated with Claude Code