Repository navigation
feat(milvus): record benchmark metadata and stage events - #897
Open
jamesgao-jpg wants to merge 4 commits into
Open
jamesgao-jpg wants to merge 4 commits into
jamesgao-jpg wants to merge 4 commits into
Conversation
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jamesgao-jpg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark analysis needs separate compaction timings and stage boundaries so an external collector can associate CPU, I/O and profiles with the work that produced them. This preserves the native benchmark result and adds opt-in, structured observations.
The consumer and telemetry result schema are in the orchestrator repository. The dashboard consuming these fields is in test-platform-web PR #51.
Validation: 26 targeted metadata, stage-event, worker-process, mocked segment observation, concurrency-boundary and Milvus optimization tests; Ruff on changed Python files. The segment API is mocked and no new VDBBench workload or live compaction was run. The orchestrator's independent Kubernetes collector was exercised on an existing idle UAT3 pod; this does not establish search-phase native stack quality or benchmark overhead.