Repository navigation
Fixes issue with optional chaining causing incorrect highlighting. - #106
Open
RadhiRasho wants to merge 1 commit into
Open
RadhiRasho wants to merge 1 commit into
RadhiRasho wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue which I notice was causing incorrect styling when using the optional chaining.
This is a fix specifically for the Zed C# extension. I wanted to do this here initially as I'm not sure how long the actual changes to the main tree-sitter-c-sharp project will take to get merged as a part of this.
This is an issue with the main project itself, and not just the Zed C# extension.
Below is a video demonstrating the issue with the current version and the local version which has the fix for it:
Zed_vAnQiDGpdb.mp4
Again, this is something that is fixed by simply turning on the Semantic Tokens setting to either "Combined" or "Full" which relies heavily on the LSP itself, rather than tree-sitter. However, since by default that setting is set to "Off", I believe there should be something to address this issue within the tree-sitter highlighting.
I do believe this is still something that should be resolved more upstream rather than scoped to the Zed extension itself.
Fixes following issue which I opened: #105