Skip test_pyzstd when pyzstd cannot be imported#845
Merged
Conversation
On i386 (Alpine, Python 3.14), pyzstd 0.17+ delegates to the stdlib compression.zstd module, which requires the _zstd C extension that is not built on that platform. The hard top-level `import pyzstd` turned this into a collection error, failing the entire test run. Guard the import with pytest.importorskip so the module is skipped instead of erroring when pyzstd is unavailable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 901 901
=========================================
Hits 901 901 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On i386 (Alpine, Python 3.14), pyzstd 0.17+ delegates to the stdlib
compression.zstd module, which requires the _zstd C extension that is
not built on that platform. The hard top-level
import pyzstdturnedthis into a collection error, failing the entire test run.
Guard the import with pytest.importorskip so the module is skipped
instead of erroring when pyzstd is unavailable.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
[Description of PR]
TODO: