Do not decode unknown agents as Claude - #4
Open
Adam-Dalloul wants to merge 2 commits into
Open
Conversation
Unknown and custom:* agents used to decode as a single case and encode back as "custom" or, on older builds, as Claude. Keep the original wire token, use the server icon_url when present, and never render Grok or extra accounts as Claude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentTypeused to decode any unrecognized wire value as Claude so a new server-side agent would not break list decode.That also made Grok (on builds that shipped before the
grokcase) and everycustom:extra account render with Claude's name and mark. A later encode then sentcustominstead ofcustom:<id>.Unknown built-in ids now decode as
.unknown(raw)andcustom:values keep the original wire token. Custom agents use the servericon_urlwhen present. Neither case impersonates Claude.