Skip to content

Use Ruby 3.4.9, Bundler 4.0.22, and Xcode 26.6 - #64

Merged
AliSoftware merged 2 commits into
trunkfrom
iangmaia/ainfra-2860-use-ruby-349
Oct 5, 2026
Merged

AliSoftware merged 2 commits into
trunkfrom
iangmaia/ainfra-2860-use-ruby-349

Conversation

@iangmaia

@iangmaia iangmaia commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Fixes AINFRA-2860

  • Update Ruby to 3.4.9 and Bundler to 4.0.22
  • Use the Xcode 26.6 CI image (the first one with Ruby 3.4.9)
  • Run tests on iPhone 17
  • Raise the Xcode project's deployment target to iOS 15, matching Package.swift

To test (Xcode 26.6):

bundle install
bundle exec fastlane test
bundle exec rubocop

Note: on Xcode 27, the Example app will need the UIScene life cycle to launch on iOS 27 simulators.


PR submission checklist:

  • I have considered adding unit tests where possible. (No behavior change.)
  • I have considered adding accessibility improvements for my changes. (N/A)
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary. (Tooling only, so none needed.)

🤖 Generated with Claude Code

iangmaia and others added 2 commits October 5, 2026 14:29
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@iangmaia iangmaia self-assigned this Oct 5, 2026
@iangmaia
iangmaia marked this pull request as ready for review October 5, 2026 15:17
Copilot AI balanced review requested due to automatic review settings October 5, 2026 15:17
@iangmaia
iangmaia requested a review from a team as a code owner October 5, 2026 15:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The tooling and deployment-target updates are consistent with the stated purpose and existing package requirements.

Review effort: Balanced
Findings: None

What changed in this PR

Updates the development and CI toolchain while aligning deployment targets.

Changes:

  • Upgrades Ruby, Bundler, and the Buildkite Xcode image.
  • Runs tests on iPhone 17.
  • Aligns the Xcode project with the iOS 15 package minimum.
File Description
.ruby-version Selects Ruby 3.4.9.
.buildkite/​pipeline.yml Uses Xcode 26.6.
Gemfile.lock Records Bundler 4.0.22.
fastlane/​Fastfile Tests with iPhone 17.
MediaEditor.xcodeproj/​project.pbxproj Raises deployment targets to iOS 15.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
IPHONEOS_DEPLOYMENT_TARGET = 15.0;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this won't cause any problem because I doubt any adopter of this library is using a deployment target <15.0 nowadays (I think WPiOS is the only one of our own apps using it?); but worth noting that this will thus be a breaking change to the library for the next time we'll do a new version…

@AliSoftware
AliSoftware merged commit 022c552 into trunk Oct 5, 2026
5 checks passed
@AliSoftware
AliSoftware deleted the iangmaia/ainfra-2860-use-ruby-349 branch October 5, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants