Repository navigation
Use Ruby 3.4.9, Bundler 4.0.22, and Xcode 26.6 - #64
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The tooling and deployment-target updates are consistent with the stated purpose and existing package requirements.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the development and CI toolchain while aligning deployment targets.
Changes:
- Upgrades Ruby, Bundler, and the Buildkite Xcode image.
- Runs tests on iPhone 17.
- Aligns the Xcode project with the iOS 15 package minimum.
| File | Description |
|---|---|
.ruby-version |
Selects Ruby 3.4.9. |
.buildkite/pipeline.yml |
Uses Xcode 26.6. |
Gemfile.lock |
Records Bundler 4.0.22. |
fastlane/Fastfile |
Tests with iPhone 17. |
MediaEditor.xcodeproj/project.pbxproj |
Raises deployment targets to iOS 15. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AliSoftware
approved these changes
Oct 5, 2026
| GCC_WARN_UNUSED_FUNCTION = YES; | ||
| GCC_WARN_UNUSED_VARIABLE = YES; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 12.0; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 15.0; |
Contributor
There was a problem hiding this comment.
I'm pretty sure this won't cause any problem because I doubt any adopter of this library is using a deployment target <15.0 nowadays (I think WPiOS is the only one of our own apps using it?); but worth noting that this will thus be a breaking change to the library for the next time we'll do a new version…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AINFRA-2860
Package.swiftTo test (Xcode 26.6):
Note: on Xcode 27, the Example app will need the UIScene life cycle to launch on iOS 27 simulators.
PR submission checklist:
CHANGELOG.mdif necessary. (Tooling only, so none needed.)🤖 Generated with Claude Code