fix GCM tls iv length check and aead tag length validation#416
Open
gasbytes wants to merge 2 commits into
Open
fix GCM tls iv length check and aead tag length validation#416gasbytes wants to merge 2 commits into
gasbytes wants to merge 2 commits into
Conversation
… than the iv buffer
There was a problem hiding this comment.
Pull request overview
This PR tightens AES-GCM/TLS fixed-IV handling and AEAD tag-length validation in wp_aes_aead.c, and adds unit tests to prevent regressions around oversized fixed-IV inputs and undersized authentication tags.
Changes:
- Add
wp_aead_tag_len_valid()and enforce algorithm-specific allowed tag sizes for GCM and CCM when settingOSSL_CIPHER_PARAM_AEAD_TAG. - Fix AES-GCM TLS fixed-IV length validation to reject oversized fixed-IV lengths (including those exceeding the configured IV length).
- Add new unit tests covering oversized GCM TLS fixed-IV inputs and undersized tag-length rejection for both GCM and CCM.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/unit.h | Declares new GCM/CCM regression tests. |
| test/unit.c | Registers the new tests in the unit test suite. |
| test/test_aestag.c | Implements new test cases for oversized TLS fixed-IV and undersized tag length rejection. |
| src/wp_aes_aead.c | Adds tag-length validation helper and tightens GCM TLS fixed-IV length checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aececf4 to
4f8d057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the gcm tls fixed-iv length check to properly reject oversized inputs and adds tag length validation against each algorithm's allowed sizes for GCM and CCM, in particular this last one was wrapped in a new function called wp_aead_tag_len_valid.