Repository navigation
Conversation
wolfSSL master now rejects a HashML-DSA pre-hash weaker than the ML-DSA parameter set (wolfSSL PR #11668, FIPS 204 section 5.4), so ML-DSA-65 with a SHA-256 pre-hash fails with PSA_ERROR_INVALID_ARGUMENT. That broke psa_mldsa_test and psa_sign_context_test on the wolfSSL master CI lane. Switch both ML-DSA-65 cases to SHA-384, which matches the 192-bit parameter set and passes against wolfSSL master and v5.9.4-stable. SHA-256 HashML-DSA stays covered with ML-DSA-44 in psa_mldsa_any_hash_test, psa_mldsa_det_sign_test and psa_copy_key_narrowing_test.
There was a problem hiding this comment.
🟢 Approval recommended
The test-only changes consistently apply SHA-384 while preserving existing assertions, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates ML-DSA-65 unit tests to use SHA-384, matching wolfSSL’s minimum pre-hash strength requirement.
Changes:
- Switches interoperability and context tests from SHA-256 to SHA-384.
- Updates digest buffers, algorithm selections, and test descriptions consistently.
| File | Description |
|---|---|
| test/psa_server/psa_sign_context_test.c | Uses SHA-384 for context-aware HashML-DSA-65 signing and verification. |
| test/psa_server/psa_mldsa_test.c | Uses SHA-384 for HashML-DSA-65 cross-path interoperability tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfSSL master now rejects a HashML-DSA pre-hash weaker than the parameter set (wolfSSL/wolfssl#11668, FIPS 204 section 5.4). That breaks
psa_mldsa_testandpsa_sign_context_teston the wolfSSL master CI lane, where ML-DSA-65 with SHA-256 now returnsPSA_ERROR_INVALID_ARGUMENT. It also failstest-psa-api (master)on every open PR (for example #35).psa_mldsa_any_hash_test,psa_mldsa_det_sign_testandpsa_copy_key_narrowing_test.Tested: both tests pass against wolfSSL master and v5.9.4-stable.