Fix to match OpenSSL test behavior#347
Open
embhorn wants to merge 1 commit into
Open
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
Updates the wolfSSL Python patchsets to align CPython’s test_ssl certificate-parsing expectations with the newer wolfSSL/OpenSSL behavior referenced in wolfSSL PR #10793, unblocking failing Python test suites across supported Python versions.
Changes:
- Adjust
test_parse_cert_CVE_2013_4238expectations for wolfSSL to validate decoded SAN content (including embedded NULs) instead of expecting a parsing failure. - Add a wolfSSL-specific SAN ordering expectation for the NULL-byte certificate test.
- Apply the same behavioral alignment consistently to the 3.12.11, 3.13.4, and 3.13.7 patch files.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Python/wolfssl-python-3.13.7.patch | Updates CPython SSL test expectations for wolfSSL SAN parsing/order for the NULL-byte cert case. |
| Python/wolfssl-python-3.13.4.patch | Same test expectation adjustment as 3.13.7, applied to the 3.13.4 patchset. |
| Python/wolfssl-python-3.12.11.patch | Same test expectation adjustment, applied to the 3.12.11 patchset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| p = ssl._ssl._test_decode_cert(NULLBYTECERT) | ||
| if support.verbose: | ||
| sys.stdout.write("\n" + pprint.pformat(p) + "\n") | ||
| + # wolfSSL preserves the embedded NULs and lists SAN entries in a different order. |
| p = ssl._ssl._test_decode_cert(NULLBYTECERT) | ||
| if support.verbose: | ||
| sys.stdout.write("\n" + pprint.pformat(p) + "\n") | ||
| + # wolfSSL preserves the embedded NULs and lists SAN entries in a different order. |
| p = ssl._ssl._test_decode_cert(NULLBYTECERT) | ||
| if support.verbose: | ||
| sys.stdout.write("\n" + pprint.pformat(p) + "\n") | ||
| + # wolfSSL preserves the embedded NULs and lists SAN entries in a different order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Python tests after changes in wolfSSL/wolfssl#10793