Skip to content

[WFLY-20952] Added integration tests to the JTS quickstart#1179

Merged
emmartins merged 6 commits into
wildfly:mainfrom
jmfinelli:WFLY-20952
Jun 29, 2026
Merged

[WFLY-20952] Added integration tests to the JTS quickstart#1179
emmartins merged 6 commits into
wildfly:mainfrom
jmfinelli:WFLY-20952

Conversation

@jmfinelli

@jmfinelli jmfinelli commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Addresses WFLY-20952

@jmfinelli jmfinelli requested a review from emmartins as a code owner June 19, 2026 10:50
@jmfinelli jmfinelli requested a review from kstekovi June 19, 2026 10:51
Comment thread jts/README-source.adoc Outdated
Comment thread jts/README-source.adoc

@kstekovi kstekovi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the integration tests added to the JTS quickstart.

@kstekovi kstekovi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late comments — these should have been caught in the first review round but I ran out of time yesterday.

Comment thread jts/README-source.adoc
@kstekovi

Copy link
Copy Markdown
Contributor

Nitpick on jts/README-source.adoc (pre-existing, out of scope for this PR): the AsciiDoc build emits warnings at lines 157, 165, 172 — list item index: expected N, got 1 — because the PostgreSQL driver setup section repeats 1. for each numbered step instead of using explicit numbering (1., 2., 3., 4.). This has no effect on the rendered output; the HTML displays the correct sequence. The fix would be replacing the repeated 1. with explicit indices.

@jmfinelli jmfinelli requested a review from emmartins June 25, 2026 09:40

@kstekovi kstekovi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All review comments from both rounds have been addressed. The integration tests are well structured, the timing issues are handled correctly with polling helpers, the management client dependency has been cleanly replaced with a REST endpoint, and the README now documents the expected warnings for both deployment and integration test phases. LGTM!

@emmartins emmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we need one more round.

Comment thread jts/README-source.adoc Outdated
Comment thread jts/README-source.adoc Outdated
Comment thread jts/README-source.adoc Outdated
Comment thread jts/README-source.adoc Outdated
Comment thread jts/README-source.adoc Outdated
Comment thread jts/README-source.adoc Outdated
@emmartins

Copy link
Copy Markdown
Contributor

Thanks @jmfinelli

@emmartins emmartins requested a review from kstekovi June 29, 2026 15:06

@emmartins emmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed something

@jmfinelli jmfinelli requested a review from emmartins June 29, 2026 16:10
@emmartins

Copy link
Copy Markdown
Contributor

@jmfinelli this is the way, thank you

@emmartins emmartins merged commit 2dd49f2 into wildfly:main Jun 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants