Skip to content

Fix Cancel to close the ballot address modal - #4990

Merged
DaleMcGrew merged 1 commit into
wevote:developfrom
ckedev:WV-4807_fix-ballot-address-modal-cancel
Nov 14, 2026
Merged

DaleMcGrew merged 1 commit into
wevote:developfrom
ckedev:WV-4807_fix-ballot-address-modal-cancel

Conversation

@ckedev

@ckedev ckedev commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

JIRA - https://wevoteusa.atlassian.net/browse/WV-4807

Description:

On the Ballot page, clicking the address next to "Ballot for" opens the address editor. Clicking Cancel previously hid the form and showed the election picker, leaving the modal open. Cancel now closes the entire modal without saving changes, just like the × button.

Added a test, verifyBallotAddressModalClosesOnCancel, that checks the modal closes after clicking Cancel.

if (this.props.toggleEditingAddress) {
this.props.toggleEditingAddress();
}
this.incomingToggleSelectAddressModal();

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toggleEditingAddress() hid the address form but left the modal open on the election picker. This call uses the same close handler as the × button, so Cancel closes the modal and resets address edit mode

@ckedev
ckedev marked this pull request as draft November 13, 2026 22:11
@DaleMcGrew

Copy link
Copy Markdown
Member

Thank you @ckedev, and congratulations on your first WeVote pull request! 👍

@DaleMcGrew
DaleMcGrew marked this pull request as ready for review November 14, 2026 01:37
@DaleMcGrew
DaleMcGrew merged commit 675123b into wevote:develop Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants