Repository navigation
Fix Cancel to close the ballot address modal - #4990
Merged
DaleMcGrew merged 1 commit intoNov 14, 2026
Merged
Conversation
ckedev
commented
Nov 13, 2026
| if (this.props.toggleEditingAddress) { | ||
| this.props.toggleEditingAddress(); | ||
| } | ||
| this.incomingToggleSelectAddressModal(); |
Contributor
Author
There was a problem hiding this comment.
toggleEditingAddress() hid the address form but left the modal open on the election picker. This call uses the same close handler as the × button, so Cancel closes the modal and resets address edit mode
ckedev
marked this pull request as draft
November 13, 2026 22:11
Member
|
Thank you @ckedev, and congratulations on your first WeVote pull request! 👍 |
DaleMcGrew
marked this pull request as ready for review
November 14, 2026 01:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA - https://wevoteusa.atlassian.net/browse/WV-4807
Description:
On the Ballot page, clicking the address next to "Ballot for" opens the address editor. Clicking
Cancelpreviously hid the form and showed the election picker, leaving the modal open.Cancelnow closes the entire modal without saving changes, just like the×button.Added a test,
verifyBallotAddressModalClosesOnCancel, that checks the modal closes after clickingCancel.