Skip to content

Should not catch all exceptions #21

Description

@antoineleclair

except:

In the event of some other errors, the exception is just swallowed. For example, a network error. You should list the exceptions that you want to catch.

And I think the code expects that an exception will be raised if the status code is 4xx/5xx, but, as far as I know, it's not the case.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions